[BUG] Summary report "Files in use" metric reports incorrect/impossible figure
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Mar 18 2019, 2:59 PM

Description

The Summary report is reporting an incorrect "Files in use" figure.

For example, https://eventmetrics-dev.wmflabs.org/programs/108/events/223 has files uploaded = 13, files in use = 15, which isn't possible.

Expected behavior:
I believe the correct figure is 8.
Observed behavior:
It reports 15.

Mentioned In: T205734: Add support for Category filtering without Participants
rGEVM46c909b8fe32: Fix used files metric following #222 refactor
Mentioned Here: T219379: [BUG] "Files in use" metric includes files used on non-mainspace pages

Regression following the 050022c refactor.

Fixed with https://github.com/wikimedia/eventmetrics/pull/233. Better integration tests to come later after we get all the category without participants stuff merged in.

Merged

@MaxSem to help with QA here after @MusikAnimal helps him with access

@MaxSem User:MaxSem_(WMF) has been added as an admin to https://eventmetrics-dev.wmflabs.org

The Files in use metric was tested as part of T219379. I saw no inaccuracies in the figures for the events I have checked so far.

Thanks everyone. Good work. Closing this.