Page MenuHomePhabricator

Remove HTMLDiff
Closed, ResolvedPublic

Description

HTMLDiff is terribly broken. It's been an i18n nightmare since the start and doesn't function correctly a lot of the time. I think this experimental feature should be removed.

Bugs 18872, 17812 and 15328 can probably be INVALID if we nuke HTMLDiff.


Version: unspecified
Severity: enhancement
See also: T20872, T19812, T17328

Details

Reference
bz19859

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:39 PM
bzimport set Reference to bz19859.
bzimport added a subscriber: Unknown Object (MLST).
demon created this task.Jul 21 2009, 1:30 PM
demon added a comment.Jul 21 2009, 2:21 PM

Created attachment 6378
Remove HTMLDiff Entirely

  • Remove HTMLDiff and all dependent stuff, nuke UI, nuke $wgEnableHTMLDiff
    • Removed $htmldiff param in DifferenceEngine constructor, updated single caller that passed this
  • Remove now useless Node classes and children, update Autoloader
  • Nuke all diff-* messages except diff-multi, visualcomparison, visual-comparison and wikicodecomparison

Attached:

demon added a comment.Oct 28 2009, 6:21 PM

Done in r58267.