Page MenuHomePhabricator
Create Task
Maniphest T218598

Generate code coverage and make it available to wmf-sonar-scanner
Closed, ResolvedPublic
Actions

Description

The wmf-sonar-scanner job hopes to find code coverage reports (see run.sh for example) and if they are found, they will be incorporated into the analysis.

Some problems to figure out:

  1. We need a way to have the code coverage job(s) (plural -- because MobileFrontend for example has both PHP and JS code coverage reports) run before the wmf-sonar-scanner job.
  2. We need a solution that can work for Python, Java, PHP, JS, etc and does not assume that the project we are looking at is a Mediawiki Extension or Mediawiki core. (However starting with just core + extensions would be reasonable.)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Codehealth: Change sonar-scanner to a publisherintegration/configmaster+27 -23
Codehealth pipeline: Ignore exit code of npm test:unitintegration/configmaster+3 -1
Codehealth: Allow jobs to execute concurrentlyintegration/configmaster+1 -1
Codehealth: Make patch job votingintegration/configmaster+2 -2
Establish codehealth pipeline, enable for GrowthExperiments onlyintegration/configmaster+105 -79
Generate junit.xml for sonar-scanner's usageintegration/configmaster+79 -1
sonar-scanner: Use relative paths and mount to /workspace/srcintegration/configmaster+29 -13
sonar-scanner: Adjust polling script, drop JSON pretty-print outputintegration/configmaster+15 -4
Bump java8-sonar-scanner to 0.4.2integration/configmaster+22 -8
Invoke wmf-sonar-scanner after PHP code coverage is generatedintegration/configmaster+16 -24
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Mar 18 2019, 4:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2019, 4:41 PM
• Jrbranaa subscribed.Mar 18 2019, 10:11 PM
zeljkofilipin added a comment.Apr 1 2019, 2:46 PM

Blocked on T208522?

kostajh claimed this task.Apr 5 2019, 7:48 PM
kostajh moved this task from Backlog to In-Progress on the Code-Health-Metrics board.
gerritbot added a comment.Apr 5 2019, 7:52 PM

Change 501685 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] (wip) Invoke wmf-sonar-scanner after code coverage is generated

https://gerrit.wikimedia.org/r/501685

gerritbot added a project: Patch-For-Review.Apr 5 2019, 7:52 PM
gerritbot added a comment.Apr 9 2019, 8:42 PM

Change 502606 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Establish codehealth pipeline

https://gerrit.wikimedia.org/r/502606

gerritbot added a comment.Apr 9 2019, 8:42 PM

Change 501685 abandoned by Kosta Harlan:
Invoke wmf-sonar-scanner after PHP code coverage is generated

Reason:
Abandoning in favor of https://gerrit.wikimedia.org/r/#/q/If503cf3de069566a9058404d0b4cbc9c167463dc

https://gerrit.wikimedia.org/r/501685

gerritbot added a comment.May 3 2019, 7:03 PM

Change 508006 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Bump java8-sonar-scanner to 0.4.2

https://gerrit.wikimedia.org/r/508006

gerritbot added a comment.May 3 2019, 8:06 PM

Change 508019 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Generate junit.xml for sonar-scanner's usage

https://gerrit.wikimedia.org/r/508019

gerritbot added a comment.May 3 2019, 8:44 PM

Change 508006 merged by jenkins-bot:
[integration/config@master] Bump java8-sonar-scanner to 0.4.2

https://gerrit.wikimedia.org/r/508006

gerritbot added a comment.May 4 2019, 3:50 PM

Change 508086 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] sonar-scanner: Adjust polling script

https://gerrit.wikimedia.org/r/508086

gerritbot added a comment.May 6 2019, 9:50 PM

Change 508086 merged by jenkins-bot:
[integration/config@master] sonar-scanner: Adjust polling script, drop JSON pretty-print output

https://gerrit.wikimedia.org/r/508086

gerritbot added a comment.May 8 2019, 8:35 PM

Change 508929 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] sonar-scanner: Use relative paths and mount to /workspace/src

https://gerrit.wikimedia.org/r/508929

gerritbot added a comment.May 9 2019, 12:15 AM

Change 508929 merged by jenkins-bot:
[integration/config@master] sonar-scanner: Use relative paths and mount to /workspace/src

https://gerrit.wikimedia.org/r/508929

gerritbot added a comment.May 13 2019, 3:04 PM

Change 508019 merged by jenkins-bot:
[integration/config@master] Generate junit.xml for sonar-scanner's usage

https://gerrit.wikimedia.org/r/508019

gerritbot added a comment.May 13 2019, 7:45 PM

Change 502606 merged by jenkins-bot:
[integration/config@master] Establish codehealth pipeline, enable for GrowthExperiments only

https://gerrit.wikimedia.org/r/502606

gerritbot added a comment.May 13 2019, 8:09 PM

Change 509930 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Codehealth: Make patch job voting

https://gerrit.wikimedia.org/r/509930

gerritbot added a comment.May 13 2019, 8:18 PM

Change 509930 merged by jenkins-bot:
[integration/config@master] Codehealth: Make patch job voting

https://gerrit.wikimedia.org/r/509930

gerritbot added a comment.May 13 2019, 8:52 PM

Change 509943 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Codehealth pipeline: Ignore exit code of npm test:unit

https://gerrit.wikimedia.org/r/509943

gerritbot added a comment.May 13 2019, 8:55 PM

Change 509944 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Codehealth: Allow jobs to execute concurrently

https://gerrit.wikimedia.org/r/509944

kostajh moved this task from In-Progress to Done on the Code-Health-Metrics board.May 14 2019, 2:06 PM
gerritbot added a comment.May 14 2019, 7:54 PM

Change 509944 merged by jenkins-bot:
[integration/config@master] Codehealth: Allow jobs to execute concurrently

https://gerrit.wikimedia.org/r/509944

gerritbot added a comment.May 15 2019, 12:02 AM

Change 509943 merged by jenkins-bot:
[integration/config@master] Codehealth pipeline: Ignore exit code of npm test:unit

https://gerrit.wikimedia.org/r/509943

gerritbot added a comment.May 17 2019, 9:10 AM

Change 510824 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[integration/config@master] Change sonar-scanner to a publisher

https://gerrit.wikimedia.org/r/510824

gerritbot added a comment.May 17 2019, 11:12 AM

Change 510824 merged by jenkins-bot:
[integration/config@master] Codehealth: Change sonar-scanner to a publisher

https://gerrit.wikimedia.org/r/510824

kostajh closed this task as Resolved.Aug 19 2019, 1:51 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 19 2019, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits