Page MenuHomePhabricator

Make pywikibot update on PAWS failsafe
Closed, ResolvedPublic

Description

Currently we clone pywikibot from gerrit and use a PostStart k8s hook to git pull and update pywikibot on each notebook server start. (changing this is discussed in T217908)

If gerrit is down, the PostStart hook will fail and k8s will kill the pod to start a new one (that will fail again).

We should find a way to keep pywikibot updated without this risk.

Event Timeline

Chicocvenancio moved this task from Backlog to MVP (Most Valuable PAWS) on the PAWS board.

To be clear, I disabled the update during the gerrit outage today to bring PAWS into a working state.

Chicocvenancio triaged this task as High priority.Mar 18 2019, 9:57 PM

Adding a || exit 0 to the command should work. It does make the failure transparent to the user and maybe we want to warn users pywikibot won't be updated, or perhaps try another source. But seems like a good enough solution for now to me.

Chicocvenancio closed this task as Resolved.Mar 18 2019, 11:18 PM
Xqt added a subscriber: Xqt.Mar 19 2019, 6:44 AM

The github mirror could be used in such case

The || exit 0 solution solves the taking PAWS offline problem. But obviously makes pywikibot a bit outdated.

The github mirror could be used in such case

Sure, it does mean adding a new remote and pulling from it. PRs are welcome https://github.com/yuvipanda/paws

Xqt added a comment.Mar 19 2019, 10:52 AM

Migrating repo to gerrit would be easier for me ;)

Migrating repo to gerrit would be easier for me ;)

Touché