Page MenuHomePhabricator
Create Task
Maniphest T218639

Make language-data installable as a proper library
Closed, ResolvedPublic
Actions

Description

Language-data is hosted in https://github.com/wikimedia/language-data

It does have a package.json, but as far as I can see, it doesn't have any releases nor is it submitted to npm. It is not submitted to packagist.

Currently, I believe, composer dependencies are easier to add to MediaWiki core.

Steps to do

  • Establish a release policy (who, when, semantic versioning)
  • Make a release in GitHub
  • Register language-data in npm
  • Add composer.json and register in packagist

QA plan

Affected projects: none
Verify that projects are installable via composer and npm

Outcome

Language-data library is released in Packagist and NPM package repositories

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Mar 19 2019, 7:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2019, 7:39 AM
Nikerabbit added a parent task: T190129: Consolidate language metadata into a 'language-data' library and use in MediaWiki.Mar 19 2019, 7:39 AM
Nikerabbit mentioned this in T190129: Consolidate language metadata into a 'language-data' library and use in MediaWiki.
Liuxinyu970226 added a subscriber: Liuxinyu970226.Mar 19 2019, 10:42 AM
Pginer-WMF triaged this task as Medium priority.Oct 9 2019, 2:07 PM
Pginer-WMF edited projects, added Language-Team (Language-2019-October-December); removed Language-Team.
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-October-December) board.
Pginer-WMF moved this task from Priority backlog to Backlog on the Language-Team (Language-2019-October-December) board.Oct 10 2019, 9:18 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-October-December) board.Nov 18 2019, 12:14 PM
santhosh added a subscriber: santhosh.Nov 19 2019, 5:06 AM

https://github.com/wikimedia/language-data is now available in npm https://www.npmjs.com/package/@wikimedia/language-data

2 versions were released so far. Latest is 0.1.2 - https://www.npmjs.com/package/@wikimedia/language-data?activeTab=versions

Pginer-WMF edited projects, added Language-Team (Language-2020-January-March); removed Language-Team (Language-2019-October-December).Jan 2 2020, 8:11 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2020-January-March) board.
abi_ claimed this task.Jan 17 2020, 6:11 AM
abi_ moved this task from Priority backlog to In Progress on the Language-Team (Language-2020-January-March) board.
abi_ added a comment.EditedFeb 2 2020, 6:00 AM

I've submitted the following patches

  1. Add a PHP Interface and test cases - https://github.com/wikimedia/language-data/pull/79
  2. Replace TravisCI with Github actions - https://github.com/wikimedia/language-data/pull/80
  3. Move documentation to Read the docs - https://github.com/wikimedia/language-data/pull/81
  4. Add spyc to composer.json - https://github.com/wikimedia/language-data/pull/82
  5. Update minimum supported node.js version to 8.x - https://github.com/wikimedia/language-data/pull/83

After the above patches have been merged we've to do the following,

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2020-January-March) board.Feb 2 2020, 6:01 AM
• Rileych edited projects, added Language-Team (Language-2020-Focus-Sprint); removed Language-Team (Language-2020-January-March).Mar 18 2020, 2:03 PM
• Rileych moved this task from Priority Backlog to In Review on the Language-Team (Language-2020-Focus-Sprint) board.
Arrbee edited projects, added Language-Team (Language-2020-January-March); removed Language-Team (Language-2020-Focus-Sprint).Mar 19 2020, 1:31 PM
abi_ edited projects, added Language-Team (Language-2020-Focus-Sprint); removed Language-Team (Language-2020-January-March).May 14 2020, 1:52 PM
Nikerabbit mentioned this in T252987: Requesting access to wikimedia namespace in packagist.May 18 2020, 7:28 AM
bd808 added a subtask: T252987: Requesting access to wikimedia namespace in packagist.May 18 2020, 9:38 PM
Krinkle added a subscriber: Krinkle.May 18 2020, 9:54 PM
From GitHub:

wikimedia / language-data
(forked from santhoshtr/language-data)

You may want to re-create/push either the wikimedia or the santhoshtr one to break (or reverse) this link so that GitHub's code search isn't disabled, and to ensure contributes and GH's automatic PRs don't encourage the user to go to the old repo instead. E.g. right now it says "This branch is 22 commits ahead" and new PRs that you create internally will defaullt to upstream/master instead of local master.

bd808 mentioned this in T253079: Document how to get new packages published under the 'wikimedia' and 'mediawiki' namespaces on Packagist.May 18 2020, 11:10 PM
santhosh added a comment.May 19 2020, 6:03 AM
In T218639#6146808, @Krinkle wrote:
From GitHub:

wikimedia / language-data
(forked from santhoshtr/language-data)

You may want to re-create/push either the wikimedia or the santhoshtr one to break (or reverse) this link so that GitHub's code search isn't disabled, and to ensure contributes and GH's automatic PRs don't encourage the user to go to the old repo instead. E.g. right now it says "This branch is 22 commits ahead" and new PRs that you create internally will defaullt to upstream/master instead of local master.

Fixed.

Nikerabbit closed subtask T252987: Requesting access to wikimedia namespace in packagist as Resolved.May 19 2020, 10:26 AM
abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2020-Focus-Sprint) board.May 26 2020, 9:27 AM

We've released updated versions of the library on npm (v0.2.0) and packagist (v1.0.0).

  1. Documentation is available here
  2. The changelog is available here.
  3. Subsequent releases will be done along with the MLEB release i.e once every quarter.
Nikerabbit updated the task description. (Show Details)May 28 2020, 11:28 AM
Krinkle removed a subscriber: Krinkle.May 28 2020, 2:31 PM
Nikerabbit closed this task as Resolved.Jun 16 2020, 8:26 AM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2020-Focus-Sprint) board.

I did:

jadekukka:~/foo$ npm i @wikimedia/language-data
npm WARN npm npm does not support Node.js v10.21.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 4, 6, 7, 8, 9.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN saveError ENOENT: no such file or directory, open '/home/nike/foo/package.json'
npm notice created a lockfile as package-lock.json. You should commit this file.
npm WARN enoent ENOENT: no such file or directory, open '/home/nike/foo/package.json'
npm WARN foo No description
npm WARN foo No repository field.
npm WARN foo No README data
npm WARN foo No license field.

+ @wikimedia/language-data@0.2.0
added 1 package from 5 contributors in 3.864s
jadekukka:~/foo$ composer require wikimedia/language-data
Using version ^1.0 for wikimedia/language-data
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 2 installs, 0 updates, 0 removals
  - Installing mustangostang/spyc (0.6.3): Downloading (100%)         
  - Installing wikimedia/language-data (1.0.0): Downloading (100%)         
Writing lock file
Generating autoload files
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL