Have CI run seccheck tests
Closed, ResolvedPublic
Actions

Description

To ensure nothing breaks without having to run them locally. Currently you can run such tests with runtests.sh.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/tools/phan/SecurityCheckPlugin	master	+56 -5	Move regression test to PHPUnit
	mediawiki/tools/phan/SecurityCheckPlugin	2.x	+56 -5	Move regression test to PHPUnit

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Reedy	T196206 Bump symfony libraries when we no longer need hhvm support
Resolved	Reedy	T234766 Consider what PHP 7.2 point release to use
Resolved	Jdforrester-WMF	T234767 Bump PHP support version in composer.json
Resolved	Jdforrester-WMF	T216166 Drop PHP 7.1 support from MediaWiki
Resolved	Jdforrester-WMF	T216165 Drop PHP 7.0 support from MediaWiki
Resolved	Jdforrester-WMF	T225457 Move all CI generic tasks from PHP70 to PHP72
Resolved	Jdforrester-WMF	T226420 Run phan secheck on PHP 7.2, not PHP 7.0
Resolved	Jdforrester-WMF	T227385 Upgrade php-ast in Seccheck CI containers
Resolved	Daimona	T227172 Upgrade taint-check to 2.0.1 in all repos
Resolved	Krinkle	T228342 Define criteria for setting explicit PHP support target for MediaWiki
Resolved	Daimona	T207344 Phan-taint-check-plugin not available for PHP > 7.0
Resolved	sbassett	T227171 Release taint-check 2.0.0
Resolved	Daimona	T216974 Update phan-taint-check-plugin to a newer phan (1.3.2)
Resolved	Daimona	T218721 Have CI run seccheck tests

Event Timeline

Daimona created this task.Mar 19 2019, 6:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2019, 6:59 PM

Daimona added a parent task: T216974: Update phan-taint-check-plugin to a newer phan (1.3.2).Mar 19 2019, 6:59 PM

Change 497651 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@master] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/497651

gerritbot added a project: Patch-For-Review.Mar 19 2019, 10:32 PM

Daimona claimed this task.Mar 19 2019, 10:33 PM

FYI, these tests should already be run via CI (as part of composer tests)

Ah, now I see. Would it still benefit from phpunit?

Change 504394 had a related patch set uploaded (by Brian Wolff; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@2.x] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/504394

Change 504394 merged by Brian Wolff:
[mediawiki/tools/phan/SecurityCheckPlugin@2.x] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/504394

Change 497651 abandoned by Brian Wolff:
Move regression test to PHPUnit

Reason:
Moved this to 2.x branch

https://gerrit.wikimedia.org/r/497651