Page MenuHomePhabricator
Create Task
Maniphest T218721

Have CI run seccheck tests
Closed, ResolvedPublic
Actions

Description

To ensure nothing breaks without having to run them locally. Currently you can run such tests with runtests.sh.

Related Objects
Search...

Event Timeline

Daimona created this task.Mar 19 2019, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2019, 6:59 PM
gerritbot added a subscriber: gerritbot.Mar 19 2019, 10:32 PM

Change 497651 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@master] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/497651

Daimona claimed this task.Mar 19 2019, 10:33 PM
Bawolff added a subscriber: Bawolff.Mar 20 2019, 1:42 PM

FYI, these tests should already be run via CI (as part of composer tests)

Daimona added a comment.Mar 20 2019, 1:47 PM

Ah, now I see. Would it still benefit from phpunit?

gerritbot added a comment.Apr 16 2019, 6:10 PM

Change 504394 had a related patch set uploaded (by Brian Wolff; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@2.x] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/504394

gerritbot added a comment.Apr 16 2019, 6:11 PM

Change 504394 merged by Brian Wolff:
[mediawiki/tools/phan/SecurityCheckPlugin@2.x] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/504394

gerritbot added a comment.Apr 16 2019, 6:16 PM

Change 497651 abandoned by Brian Wolff:
Move regression test to PHPUnit

Reason:
Moved this to 2.x branch

https://gerrit.wikimedia.org/r/497651

sbassett closed this task as Resolved.Apr 16 2019, 7:59 PM
sbassett added a subscriber: sbassett.

Cherry-picked to 2.x, original patch to master abandoned. Resolving for now.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL