Page MenuHomePhabricator

Have CI run seccheck tests
Closed, ResolvedPublic

Description

To ensure nothing breaks without having to run them locally. Currently you can run such tests with runtests.sh.

Event Timeline

Daimona created this task.Mar 19 2019, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2019, 6:59 PM

Change 497651 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@master] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/497651

Daimona claimed this task.Mar 19 2019, 10:33 PM

FYI, these tests should already be run via CI (as part of composer tests)

Ah, now I see. Would it still benefit from phpunit?

Change 504394 had a related patch set uploaded (by Brian Wolff; owner: Daimona Eaytoy):
[mediawiki/tools/phan/SecurityCheckPlugin@2.x] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/504394

Change 504394 merged by Brian Wolff:
[mediawiki/tools/phan/SecurityCheckPlugin@2.x] Move regression test to PHPUnit

https://gerrit.wikimedia.org/r/504394

Change 497651 abandoned by Brian Wolff:
Move regression test to PHPUnit

Reason:
Moved this to 2.x branch

https://gerrit.wikimedia.org/r/497651

sbassett closed this task as Resolved.Apr 16 2019, 7:59 PM
sbassett added a subscriber: sbassett.

Cherry-picked to 2.x, original patch to master abandoned. Resolving for now.