Page MenuHomePhabricator

MassMessage to email should show section header, not bot username
Open, Needs TriagePublic


MassMessage to email a couple of years ago sent the username as well as the section header, for example:

MediaWiki message delivery left a message on your talk page.	 
/* Last call for WMF grants feedback! */ new section
View message  View changes

Currently it only sends an abbreviated form of the username:

MediaWiki message de...‬ left a message on your talk page.	 
View message  ‪MediaWiki messa...‬  View changes

I would prefer it to at least include the section header, as this is particularly valuable for event announcements. Really, the bot username can be omitted entirely if we want - perhaps we could set up a special case for MassMessage as opposed to regular talk page messages, as with these usually the subject is more important than the username.

Event Timeline

Pharos created this task.Mar 19 2019, 7:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2019, 7:07 PM
Pharos added a subscriber: jeremyb.Mar 19 2019, 7:08 PM
jeremyb-phone updated the task description. (Show Details)
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 19 2019, 7:19 PM

I don't know how easy this would be to implement, but you could make a special case where, if the "user" that left a message at the talk page was the user controlled by the mass message extension, retrieve the name of the sender from the inline html comment and use that for the email instead. Alternatively, T71954 could be actioned.

JTannerWMF moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.
JTannerWMF added subscribers: Etonkovidova, JTannerWMF.

@Etonkovidova will look into this

Etonkovidova added a comment.EditedWed, Apr 24, 3:50 PM

Confirmed - presently the notification truncates the user name:

Note: For Flow-based talk pages, the notification has a different text:

The bundled notification is more brief:

SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Thu, May 2, 2:18 PM
SBisson added a subscriber: SBisson.

Triaging to "future" for the Growth team but it's possible we'll get to it as part of the effort to reduce Echo's backlog.

Here's the solutions I can think of to make the notification more understandable, in order of simplicity:

  1. Rename "MediaWiki message delivery" to something shorter so it doesn't get truncated.
  2. Revisit Echo's max length for usernames in notification text. It's possible that adding 5 or 10 characters would allow a lot more usernames to be fully displayed while keeping the average notification header's length reasonable. This would need a bit of testing with most notifications and several languages.
  3. Have MassMessage hook into Echo and do some magic. Possibly changing the event type from 'edit-user-talk' to something MassMessage-specific that has its own PresentationModel to phrase the header is a way that emphasize the message title over the sender.