Page MenuHomePhabricator
Create Task
Maniphest T218730

Make 'emailExplain' variant default behavior
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

from comments on T215939:

ejegg: Do you want to keep this as a 'variant' that needs to be triggered by that URL parameter, or would you rather this be the default behavior for any form where the donor has opted out of email lists upstream (on a banner or donatewiki)?

pcoombe: Thanks @Ejegg ! We'd be happy to make this default for anyone who opted out, and shorten our URLs by removing the variant parameter :)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make 'emailExplain' default behaviormediawiki/extensions/DonationInterfacemaster+15 -25
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Mar 19 2019, 7:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2019, 7:42 PM
• DStrine moved this task from Triage to Sprint +3 on the Fundraising-Backlog board.Apr 1 2019, 8:12 PM
• DStrine moved this task from Sprint +3 to Q3 2021-2022 on the Fundraising-Backlog board.May 28 2019, 5:10 PM
gerritbot added a comment.May 29 2019, 8:52 PM

Change 513208 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Make 'emailExplain' default behavior

https://gerrit.wikimedia.org/r/513208

gerritbot added a project: Patch-For-Review.May 29 2019, 8:52 PM
gerritbot added a comment.May 29 2019, 10:08 PM

Change 513208 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Make 'emailExplain' default behavior

https://gerrit.wikimedia.org/r/513208

Maintenance_bot removed a project: Patch-For-Review.May 29 2019, 10:10 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.8; 2019-06-04).May 29 2019, 11:00 PM
Ejegg claimed this task.May 30 2019, 4:37 AM
Ejegg triaged this task as Medium priority.
Ejegg added a project: Fundraising Sprint King Kong vs. Mozilla.
Ejegg set the point value for this task to 1.
Ejegg moved this task from Q3 2021-2022 to Current Sprint on the Fundraising-Backlog board.
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint King Kong vs. Mozilla board.
Ejegg added subscribers: spatton, Pcoombe.May 30 2019, 6:04 PM

@Pcoombe, @spatton just a heads-up that this will be rolling out along with the 'employer' field variants (T219558), hopefully later today. After that, the 'emailExplain' variant should be unnecessary so you can test the employer variants in places you're currently using emailExplain.

jgleeson moved this task from Pending Deployment to Done on the Fundraising Sprint King Kong vs. Mozilla board.May 31 2019, 2:54 PM
Pcoombe closed this task as Resolved.May 31 2019, 3:35 PM

Thanks @Ejegg! I tested this and it looks good, so have removed the code adding variant=emailExplain from banners (diff) and donatewiki (diff). Great point that this will free us up to test other variants too, I hadn't thought of that.

spatton awarded a token.May 31 2019, 4:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits