Page MenuHomePhabricator
Create Task
Maniphest T218753

Deprecate and remove 'textures' pack
Closed, ResolvedPublic
Actions

Description

'textures' is a weird collection that doesn't seem to be a good clause for our cause.
As of v0.31.0 it features:

  • transparency.svg (not in use currently), see also T141801
  • pending.gif, which is 2 KB large and should be replaced by a CSS animation

Latter is only used in SelectFileWidget (with drop target) when loading thumbnail, which is from a performance perspective counter-productive anyways. As in extra HTTP request for a 2 KB already pre-compressed file for loading a thumbnail preview.
Outside of OOUI it's used in Echo from what is easily identifiable:

Remove 'textures' pack for dev clarity and code hygiene/performance.

transparency.svg

  • Deprecate transparency.svg
  • Remove transparency.svg

pending.gif

  • Deprecate pending.gif
  • Replace all occurrences
  • Remove pending.gif
  • Remove textures pack

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update OOUI to v0.33.0mediawiki/coremaster+515 -266
[BREAKING CHANGE] Drop textures, deprecated since 0.31.1oojs/uimaster+1 -36
[BREAKING CHANGE]: Remove 'textures' packoojs/uimaster+1 -35
Update OOUI to v0.31.1mediawiki/coremaster+977 -819
themes: Provide `background` needed for PendingElement on inputsoojs/uimaster+2 -2
themes: Replace 'pending.gif' with CSS animationoojs/uimaster+78 -12
[DEPRECATING CHANGE] textures: Deprecate 'pending.gif'oojs/uimaster+8 -2
[DEPRECATING CHANGE] textures: Deprecate unused 'transparency'oojs/uimaster+8 -2
Customize query in gerrit

Related Objects

Event Timeline

Volker_E created this task.Mar 20 2019, 3:20 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2019, 3:20 AM
gerritbot subscribed.Mar 20 2019, 8:11 AM

Change 497699 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] textures: Deprecate unused 'transparency'

https://gerrit.wikimedia.org/r/497699

gerritbot added a project: Patch-For-Review.Mar 20 2019, 8:11 AM
Volker_E updated the task description. (Show Details)Mar 20 2019, 8:18 AM
gerritbot added a comment.Mar 20 2019, 3:16 PM

Change 497699 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] textures: Deprecate unused 'transparency'

https://gerrit.wikimedia.org/r/497699

gerritbot added a comment.Mar 20 2019, 5:04 PM

Change 497815 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [DEPRECATING CHANGE] textures: Deprecate 'pending.gif'

https://gerrit.wikimedia.org/r/497815

gerritbot added a comment.Mar 20 2019, 7:55 PM

Change 497855 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] themes: Replace 'pending.gif' with CSS animation

https://gerrit.wikimedia.org/r/497855

gerritbot added a comment.Mar 20 2019, 8:08 PM

Change 497815 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] textures: Deprecate 'pending.gif'

https://gerrit.wikimedia.org/r/497815

gerritbot added a comment.Mar 20 2019, 8:08 PM

Change 497855 merged by jenkins-bot:
[oojs/ui@master] themes: Replace 'pending.gif' with CSS animation

https://gerrit.wikimedia.org/r/497855

Volker_E moved this task from Backlog to Reviewing on the OOUI board.Mar 20 2019, 8:39 PM
gerritbot added a comment.Mar 20 2019, 8:52 PM

Change 497869 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] themes: Provide background needed for PendingElement on inputs

https://gerrit.wikimedia.org/r/497869

gerritbot added a comment.Mar 20 2019, 9:15 PM

Change 497869 merged by jenkins-bot:
[oojs/ui@master] themes: Provide background needed for PendingElement on inputs

https://gerrit.wikimedia.org/r/497869

Volker_E updated the task description. (Show Details)Mar 21 2019, 12:27 AM
Volker_E moved this task from Reviewing to Waiting for breaking release on the OOUI board.Mar 21 2019, 5:23 AM
Volker_E removed a project: Patch-For-Review.Mar 21 2019, 5:34 AM
gerritbot added a comment.Mar 21 2019, 4:15 PM

Change 498143 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.1

https://gerrit.wikimedia.org/r/498143

gerritbot added a project: Patch-For-Review.Mar 21 2019, 4:15 PM
gerritbot added a comment.Mar 22 2019, 7:13 PM

Change 498143 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.1

https://gerrit.wikimedia.org/r/498143

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed Patch-For-Review.Mar 22 2019, 7:21 PM
Jdforrester-WMF subscribed.

This patch landed in MediaWiki master in time for 1.33.0-wmf.23, which will go out to Wikimedia production from 2019-03-26.

gerritbot added a comment.May 28 2019, 9:16 PM

Change 512986 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[oojs/ui@master] [BREAKING CHANGE] Drop textures, deprecated since 0.31.1

https://gerrit.wikimedia.org/r/512986

gerritbot added a project: Patch-For-Review.May 28 2019, 9:16 PM
gerritbot added a comment.May 28 2019, 9:20 PM

Change 512988 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] [BREAKING CHANGE]: Remove 'textures' pack

https://gerrit.wikimedia.org/r/512988

gerritbot added a comment.May 28 2019, 10:15 PM

Change 512988 abandoned by Jforrester:
[BREAKING CHANGE]: Remove 'textures' pack

https://gerrit.wikimedia.org/r/512988

gerritbot added a comment.Jun 26 2019, 11:30 PM

Change 512986 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] Drop textures, deprecated since 0.31.1

https://gerrit.wikimedia.org/r/512986

Jdforrester-WMF moved this task from Waiting for breaking release to OOUI-0.33.0 on the OOUI board.Jun 26 2019, 11:34 PM
Jdforrester-WMF edited projects, added OOUI (OOUI-0.33.0); removed OOUI.
Volker_E closed this task as Resolved.Jun 27 2019, 2:57 AM
Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.

Horray \o/

Volker_E triaged this task as Medium priority.Jun 27 2019, 2:57 AM
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Jun 27 2019, 4:02 AM

Change 519341 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

gerritbot added a project: Patch-For-Review.Jun 27 2019, 4:02 AM
gerritbot added a comment.Jun 27 2019, 9:03 PM

Change 519341 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

Jdforrester-WMF edited projects, added MW-1.34-notes (1.34.0-wmf.13; 2019-07-09); removed Patch-For-Review.Jun 27 2019, 9:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits