ArticleFeedbackv5
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Mar 20 2019, 9:01 AM

Description

We do not run tests for ArticleFeedbackv5 (ci change) since it relied on code that was no more present in MediaWiki (T159058: ArticleFeedback - Replace usage of the jquery.appear module in favor of mediawiki.viewport).

Now that has been fixed, we can look at enabling tests again!

Details

	Subject	Repo	Branch	Lines +/-
	Re-enable CI tests for ArticleFeedbackv5 extension	integration/config	master	+1 -2
	Re-enable ArticleFeedbackv5 CI integration	integration/config	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned In: T159058: ArticleFeedback - Replace usage of the jquery.appear module in favor of mediawiki.viewport
Mentioned Here: T159058: ArticleFeedback - Replace usage of the jquery.appear module in favor of mediawiki.viewport

Event Timeline

hashar created this task.Mar 20 2019, 9:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2019, 9:01 AM

hashar mentioned this in T159058: ArticleFeedback - Replace usage of the jquery.appear module in favor of mediawiki.viewport.Mar 20 2019, 9:03 AM

Change 497792 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[integration/config@master] Re-enable CI tests for ArticleFeedbackv5 extension

https://gerrit.wikimedia.org/r/497792

gerritbot added a project: Patch-For-Review.Mar 20 2019, 3:41 PM

xSavitar claimed this task.Mar 20 2019, 3:58 PM

xSavitar added a project: User-xSavitar.

xSavitar moved this task from Backlog to Doing [WIP] on the User-xSavitar board.

xSavitar moved this task from Doing [WIP] to Under Review on the User-xSavitar board.Mar 20 2019, 4:10 PM

Change 497976 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[integration/config@master] Re-enable ArticleFeedbackv5 CI integration

https://gerrit.wikimedia.org/r/497976

Change 497976 abandoned by Jack Phoenix:
Re-enable ArticleFeedbackv5 CI integration

Reason:
Ah, I must've somehow managed to miss the other patch!

https://gerrit.wikimedia.org/r/497976

MarcoAurelio moved this task from Backlog to Repo setup on the Continuous-Integration-Config board.Apr 4 2019, 8:50 PM

Change 497792 merged by jenkins-bot:
[integration/config@master] Re-enable CI tests for ArticleFeedbackv5 extension

https://gerrit.wikimedia.org/r/497792

xSavitar moved this task from Under Review to Reviewed/Resolved on the User-xSavitar board.Apr 26 2019, 3:46 PM

xSavitar closed this task as Resolved.Apr 29 2019, 8:30 AM