Page MenuHomePhabricator

[Spike] investigate how much effort would be involved in wrapping wikibase datamodel in an Adapter
Closed, DeclinedPublic

Description

Specifics of the technical problem:

We're using some of Wikibase's js code in MediaInfo code, and it looks like that code might rapidly become obsolete.

This ticket is to get an idea of the work involved in using that code via an adapter instead of directly, so that our dependency on WikiBase JS is confined to one place, and if something changes it should be picked up by our tests.
Update: The WB datamodels are not much more than value objects. And there's the serialization back and forth to JSON. There's really not much to wrap inside an adapter, building an actual implementation ourselves immediately might not be much harder than building an adapter.

Other people to be notified (devs etc):

Probably will need a meeting of all devs to discuss at the end of this spike

Acceptance Criteria:

  • a rough idea (days) of how long it would take to create the adapter and tests
  • a set of desired tests that should cover most of the functionality of the adapter/the underlying wikibase code

Event Timeline

We'll pick this up after Other Statements release but before Annotations and machine vision.

matthiasmullie renamed this task from [Spike] investigate how much effort would be involved in wrapping wikibase.mediainfo.statements in an Adapter to [Spike] investigate how much effort would be involved in wrapping wikibase datamodel in an Adapter.May 10 2019, 6:10 AM
matthiasmullie updated the task description. (Show Details)
matthiasmullie added a subscriber: matthiasmullie.

The existing Wikibase datamodel objects continue to be supported upstream and there are no plans of removing them.
We are no longer actively working on this much, so there is no reason to pursue this any further & we'll stick with what we've got.