[Bug] No history button shown on server rendered page (grade C browsers)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• Niedzielski
	Mar 20 2019, 5:16 PM

Description

Steps to reproduce

Login, enable advanced mobile contributions and beta mode, and visit https://es.m.wikipedia.org/wiki/Simbolismo on the MinervaNeue mobile site with JavaScript enabled.
Disable JavaScript (or emulate Opera Mini browser user agent - a grade C browser) and refresh the page.

Expected results

History icon should show

Actual results

History icon does not show

Environments observed

Browser version: Chromium v73.0.3683.75
OS version: Ubuntu v18.10
Device model: Desktop
Device language: English

Check any additional observations

Observed on the beta cluster wiki
Observed on a production wiki
Observed on Vector desktop skin
Observed on MinervaNeue responsive skin
Observed while logged in
Observed while not logged in (anonymous)

Developer notes

The link is there, but the history icon is being loaded via JavaScript using skins.minerva.icons.images.variants. It should probably be also added to skins.minerva.icons.images (which avoids data-uris) to avoid impacting first paint.

QA Instructions

The goal here is to verify that the history button is visible for logged-in users in AMC mode, while using a Grade C browser, or with Javascript disabled. A list of Grade C mobile browsers are available on the Compatibility page. That's pretty much it.
Steps

Log in as an AMC user on the beta cluster
In mobile mode
Go to an article page ( Special:LongPages has a good list of imported wikipedia articles).
Disable Javascript on your browser (probably via the DevTools)
Verify that the history button is visible and leads to the Mobile:History page
Verify the above on a Grade C browser

QA Results

Status	Details
✅ Passed	T218807#5071217

Details

	Subject	Repo	Branch	Lines +/-
	Remove skins.minerva.icons.images.variants module	mediawiki/skins/MinervaNeue	master	+22 -34

Customize query in gerrit

Related Objects

Mentioned In: T213352: AMC: add history link to actions menu
Mentioned Here: T181079: [GOAL] Provide an expanded reading experience by improving the ways that users can download articles of interest for later consumption

Event Timeline

• Niedzielski created this task.Mar 20 2019, 5:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2019, 5:16 PM

The download button is by design and blocked on being able to point to Proton (T181079). As a result I've descoped this to history as I think that distinction is helpful.

Jdlrobson renamed this task from [Bug] No history button shown on server rendered page to [Bug] No history button shown on server rendered page (grade C browsers).Mar 20 2019, 6:14 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Mar 20 2019, 6:16 PM

Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.

I've looked into the clock icon usage, and even though it has a grey variant, I don't think the original black icon is actually used anywhere. However, the black version is still being loaded for the skins.minerva.icons.images.variants module.

I think we can change the fill color on the SVG to grey, then remove the grey variant from skins.minerva.icons.images.variants.

come to think of it, I don't think the profile icon in skins.minerva.icons.images.variants is being used in either it's original black or the white variant.I think if we change the profile icon to grey, we could remove the skins.minerva.icons.images.variants module entirely.

All we really need is a white variant for the clock icon, and that can be specified in skins.minerva.icons.images.

ovasileva triaged this task as High priority.Mar 21 2019, 2:25 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Web-Team-Backlog.

Change 498111 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Remove skins.minerva.icons.images.variants module

https://gerrit.wikimedia.org/r/498111

gerritbot added a project: Patch-For-Review.Mar 21 2019, 2:57 PM

Jdlrobson moved this task from To Do to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 21 2019, 3:09 PM

Jdrewniak claimed this task.Mar 21 2019, 3:25 PM

Jdrewniak moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Jdrewniak moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Jdlrobson mentioned this in T213352: AMC: add history link to actions menu.Mar 21 2019, 5:01 PM

ovasileva set the point value for this task to 2.Mar 21 2019, 5:18 PM

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 21 2019, 8:59 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 21 2019, 9:06 PM

Change 498111 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove skins.minerva.icons.images.variants module

https://gerrit.wikimedia.org/r/498111

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 22 2019, 6:01 PM

Jdlrobson moved this task from Needs More Work to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 22 2019, 8:14 PM

Jdrewniak updated the task description. (Show Details)Mar 26 2019, 4:44 PM

• Niedzielski added a project: Advanced Mobile Contributions.Mar 26 2019, 8:49 PM

• Niedzielski removed a project: Advanced Mobile Contributions.

Jdrewniak reassigned this task from Jdrewniak to Edtadros.Mar 29 2019, 1:15 PM

Jdrewniak updated the task description. (Show Details)

Test Result:Production

Status: ✅ PASS
OS: iOS
Browser: Safari on (iPhone XS Max)

Test Artifact(s):

Log in as an AMC user on the beta cluster
In mobile mode
Go to an article page ( Special:LongPages has a good list of imported wikipedia articles).
Disable Javascript on your browser (probably via the DevTools)
Verify that the history button is visible and leads to the Mobile:History page

IMG_1C33378C5FB4-1.jpeg (2×1 px, 899 KB)

IMG_B2F33EF49ED7-1.jpeg (2×1 px, 414 KB)

Verify the above on a Grade C browser

Browser: Opera Touch on (iPhone XS Max)

IMG_284C2F014086-1.jpeg (2×1 px, 442 KB)

@ovasileva I tried to find the Amazon Silk browser or Opera Mini specifically. The only one I found is Opera Touch. I'm not sure this is a Grade C browser. Please confirm before signoff

Edtadros updated the task description. (Show Details)Mar 29 2019, 11:38 PM

MBinder_WMF edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3).Apr 1 2019, 5:25 PM

MBinder_WMF moved this task from To Do to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.Apr 1 2019, 5:26 PM

Edtadros added a project: Product-QA (RW-Test-Cases).Apr 4 2019, 1:51 PM

Resolving. Tested on browser without JS.

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:39 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 2 2020, 6:39 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2020, 7:12 PM

	F28426574: es.m.wikipedia.org_wiki_Simbolismo (1).png
	Mar 20 2019, 5:16 PM

	F28426571: es.m.wikipedia.org_wiki_Simbolismo.png
	Mar 20 2019, 5:16 PM

[Bug] No history button shown on server rendered page (grade C browsers)Closed, ResolvedPublic2 Estimated Story PointsActions