Page MenuHomePhabricator
Create Task
Maniphest T218809

Mobile editor updates browser URL incorrectly if you click back with unsaved edits
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

  • Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Spain
  • Visit a page and click edit
  • Type some text in the textarea
  • Click the close icon in the top left corner
  • Confirmation message appears. Click continue editing
  • Confirm you stay in the overlay, the URL remains #/editor/0
  • Type text in textarea
  • Press browser back button
  • Confirm you stay in the overlay

Expected: the URL remains #/editor/0
Actual: the URL becomes #/

Developer notes

This was flagged during QA of T218173 and can be fixed by making the editor overlay use the new onBeforeExit callback parameter.

Details

SubjectRepoBranchLines +/-
🐛 Fix back button behaviour in editormediawiki/extensions/MobileFrontendmaster+26 -40
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Mar 20 2019, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2019, 5:18 PM
Jdlrobson mentioned this in T218173: [Bug/Regression] New talk topic edits are lost when I click browser back button.Mar 20 2019, 5:19 PM
gerritbot subscribed.Mar 20 2019, 6:21 PM

Change 493756 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Editor and VisualEditor use onBeforeExit

https://gerrit.wikimedia.org/r/493756

gerritbot added a project: Patch-For-Review.Mar 20 2019, 6:21 PM
Jdlrobson added a project: VisualEditor.Mar 20 2019, 6:21 PM
ovasileva triaged this task as Medium priority.Mar 21 2019, 9:44 AM
Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Mar 21 2019, 3:03 PM
gerritbot added a comment.Mar 21 2019, 9:00 PM

Change 493756 abandoned by Jdlrobson:
Editor and VisualEditor use onBeforeExit

Reason:
Will work on later

https://gerrit.wikimedia.org/r/493756

JTannerWMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Mar 26 2019, 3:25 PM
ovasileva set the point value for this task to 5.Mar 27 2019, 4:52 PM
gerritbot added a comment.Apr 3 2019, 6:24 PM

Change 493756 restored by Jdlrobson:
Editor and VisualEditor use onBeforeExit

https://gerrit.wikimedia.org/r/493756

gerritbot added a comment.Apr 26 2019, 6:20 PM

Change 493756 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] 🐛 Fix back button behaviour in editor

https://gerrit.wikimedia.org/r/493756

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 26 2019, 7:00 PM
Jdlrobson closed this task as Resolved.Jul 9 2019, 4:24 PM
Jdlrobson claimed this task.

Back button behaviour is fixed now thanks to https://phabricator.wikimedia.org/T218809#5141181.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 9 2019, 4:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL