Page MenuHomePhabricator

Update Gerrit /r/p/ links to /r/
Closed, ResolvedPublic

Description

At some point Gerrit changed its URL schema from starting with /r/p to just /r/. The old URL works for the web interface (for now) but not for the REST API and various git commands. We'll have to update URLs in all kinds of places (configuration, submodules, scripts, CI, vagrant, documentation...)

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+41 -2
operations/puppetproduction+1 -1
operations/puppetproduction+3 -3
operations/puppetproduction+1 -1
operations/puppetproduction+0 -40
operations/puppetproduction+0 -107
operations/puppetproduction+3 -0
operations/puppetproduction+5 -5
operations/puppetproduction+2 -2
operations/puppetproduction+2 -2
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+1 -1
operations/puppetproduction+2 -2
mediawiki/coremaster+1 -1
operations/puppetproduction+2 -2
mediawiki/extensions/SemanticImageInputmaster+5 -6
mediawiki/extensions/SemanticTasksmaster+1 -1
mediawiki/extensions/Shibbolethmaster+1 -1
integration/quibblemaster+1 -1
mediawiki/extensions/BaseHooksmaster+1 -1
mediawiki/extensions/Gitwebmaster+1 -1
mediawiki/extensions/BoilerPlatemaster+1 -1
mediawiki/extensions/EducationProgrammaster+1 -1
mediawiki/extensions/examplesmaster+1 -1
mediawiki/extensions/Wikibasemaster+3 -3
Show related patches Customize query in gerrit

Related Objects

StatusSubtypeAssignedTask
ResolvedDzahn
ResolvedDzahn
ResolvedDzahn
ResolvedPaladox
DeclinedNone
ResolvedPaladox
DeclinedNone
ResolvedPaladox
Resolvedhashar
Resolvedhashar
Resolvedhashar
ResolvedNone
ResolvedJoe
ResolvedJoe
ResolvedJdforrester-WMF
Resolvedbd808
Resolvedhashar
Resolvedhashar
Duplicatehashar
ResolvedPaladox

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 498163 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/BoilerPlate@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498163

Change 498174 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/BaseHooks@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498174

Change 498183 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/EducationProgram@master] Change /r/p/ gerrit links to /r/

https://gerrit.wikimedia.org/r/498183

Change 498190 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/examples@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498190

Change 498197 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/Gitweb@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498197

Change 498206 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[integration/quibble@master] Drop /p from Gerrit clone URL

https://gerrit.wikimedia.org/r/498206

Change 498206 merged by jenkins-bot:
[integration/quibble@master] Drop /p from Gerrit clone URL

https://gerrit.wikimedia.org/r/498206

Change 498190 merged by jenkins-bot:
[mediawiki/extensions/examples@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498190

Change 498183 merged by jenkins-bot:
[mediawiki/extensions/EducationProgram@master] Change /r/p/ gerrit links to /r/

https://gerrit.wikimedia.org/r/498183

Change 498163 merged by jenkins-bot:
[mediawiki/extensions/BoilerPlate@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498163

Change 498197 merged by jenkins-bot:
[mediawiki/extensions/Gitweb@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498197

Paladox triaged this task as High priority.Mar 21 2019, 7:53 PM

Change 498174 merged by jenkins-bot:
[mediawiki/extensions/BaseHooks@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498174

Change 498458 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/Shibboleth@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498458

Change 498463 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/SemanticImageInput@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498463

Change 498465 had a related patch set uploaded (by Nikitrain; owner: Nikitrain):
[mediawiki/extensions/SemanticTasks@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498465

Change 498458 merged by Krinkle:
[mediawiki/extensions/Shibboleth@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498458

Change 498465 merged by Umherirrender:
[mediawiki/extensions/SemanticTasks@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498465

Change 498463 merged by Umherirrender:
[mediawiki/extensions/SemanticImageInput@master] Change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498463

Change 498057 merged by Dzahn:
[operations/puppet@production] contint: change /r/p/ to /r/ for gerrit links

https://gerrit.wikimedia.org/r/498057

Change 507074 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] toollabs: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507074

Change 507088 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] openldap: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507088

Change 507087 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] toolforge: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507087

Change 507084 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] phragile: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507084

Change 507079 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] puppetmaster: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507079

Change 507077 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] statistics: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507077

Change 507076 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] authdns: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507076

Change 507075 had a related patch set uploaded (by Dzahn; owner: Paladox):
[operations/puppet@production] analytics: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507075

Change 507087 abandoned by Paladox:
toolforge: Stop cloning over /p/

Reason:
I've merged this into https://gerrit.wikimedia.org/r/#/c/operations/puppet/ /507074/

https://gerrit.wikimedia.org/r/507087

Change 507069 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] beta: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507069

Change 507070 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] zuul: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507070

Change 507072 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] scap: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507072

Change 507223 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/core@master] docs/kss/package.json: Update Gerrit /r/p/ link to /r/

https://gerrit.wikimedia.org/r/507223

Change 507070 merged by Dzahn:
[operations/puppet@production] zuul: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507070

Mentioned in SAL (#wikimedia-operations) [2019-04-30T01:30:00Z] <mutante> contint2001..then contint1001 - deleting /etc/zuul/wikimedia and letting puppet re-clone it (gerrit:507070) (T218844)

Change 507787 had a related patch set uploaded (by Paladox; owner: Paladox):
[operations/puppet@production] Gerrit: Redirect /p/(.+)/info/(.+) to /$1/info/$2

https://gerrit.wikimedia.org/r/507787

Upstream are deprecating cloning over /p/, see https://bugs.chromium.org/p/gerrit/issues/detail?id=10381#c14

Update: it's now official that /p/ is no longer supported.

Change 507223 merged by jenkins-bot:
[mediawiki/core@master] docs/kss/package.json: Update Gerrit /r/p/ link to /r/

https://gerrit.wikimedia.org/r/507223

Change 507084 merged by Dzahn:
[operations/puppet@production] phragile: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507084

Mentioned in SAL (#wikimedia-cloud) [2019-05-06T19:43:10Z] <mutante> phragile-pro: deleting /var/lib/phragile/composer and contents, deploying gerrit:507084 to reclone it for T218844

Change 507088 merged by Dzahn:
[operations/puppet@production] openldap: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507088

Mentioned in SAL (#wikimedia-operations) [2019-05-07T20:31:29Z] <mutante> gerrit2001 - temp disabling puppet - testing apache rewrites for T218844 on non-prod host

Change 507079 merged by Andrew Bogott:
[operations/puppet@production] puppetmaster: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507079

After merging the above patch I corrected the urls in /var/lib/git/operations/puppet/.git/config and /var/lib/git/operations/software/.git/config on all prod and cloud hosts.

Change 507074 merged by Andrew Bogott:
[operations/puppet@production] toolforge: update origin URL for integration/composer.git clones

https://gerrit.wikimedia.org/r/507074

Ran sudo cumin --force --timeout 500 -o json "A:all" "sed -i 's%/r/p/%/r/%' /srv/composer/.git/config" for the composer urls

Change 507069 merged by Andrew Bogott:
[operations/puppet@production] beta: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507069

Change 509143 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[operations/puppet@production] Remove unused profile::analytics::refinery::{job::guard,source}

https://gerrit.wikimedia.org/r/509143

Change 509145 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[operations/puppet@production] Remove unused statistics::aggregator

https://gerrit.wikimedia.org/r/509145

Change 507787 merged by Dzahn:
[operations/puppet@production] Gerrit: Redirect /p/(.+)/info/(.+) to /$1/info/$2

https://gerrit.wikimedia.org/r/507787

rewrite rules have been deployed to prod. we tested cloning still works. This removed a blocker for T200739

Change 509145 merged by Ottomata:
[operations/puppet@production] Remove unused statistics::aggregator

https://gerrit.wikimedia.org/r/509145

Change 509143 merged by Ottomata:
[operations/puppet@production] Remove unused profile::analytics::refinery::{job::guard,source}

https://gerrit.wikimedia.org/r/509143

Change 507075 abandoned by Paladox:
analytics: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507075

Change 507077 abandoned by Paladox:
statistics: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507077

Change 507076 merged by BBlack:
[operations/puppet@production] authdns: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507076

thcipriani assigned this task to Paladox.

Change 507787 merged by Dzahn:
[operations/puppet@production] Gerrit: Redirect /p/(.+)/info/(.+) to /$1/info/$2

https://gerrit.wikimedia.org/r/507787

This should cover the remaining edgecases.

It would be nice to merge any remaining patches @Paladox has made for individual projects; however, the scope of this task/blocking 2.16 is covered by the above change.

There is still https://gerrit.wikimedia.org/r/c/operations/puppet/+/507072 linking over here. What should we do with it?

That one still needs to get merged.

@hashar provided updates for that today. It looks good to me, but what do I know.

Change 507072 merged by Dzahn:
[operations/puppet@production] scap: Stop cloning over /p/

https://gerrit.wikimedia.org/r/507072