At some point Gerrit changed its URL schema from starting with /r/p to just /r/. The old URL works for the web interface (for now) but not for the REST API and various git commands. We'll have to update URLs in all kinds of places (configuration, submodules, scripts, CI, vagrant, documentation...)
- Mentioned In
- Blog Post: Quibble hibernated, it is time to flourish
rESHBfcfcf4e83391: Change `/r/p/` to `/r/` for gerrit links
T218963: CI outage for mediawiki/extensions/VisualEditor – job "mwext-node10-rundoc-docker" always fails and we can't merge code due to repo configuration
rEBOPd1aac7ef6670: Change `/r/p/` to `/r/` for gerrit links
rQUIBBLE91902bb2de70: Drop /p from Gerrit clone URL
T218929: Run `git submodule sync` when updating extensions.git clones
rEBHKac83cece92f4: Change `/r/p/` to `/r/` for gerrit links
T218015: Proposal: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki, Outreachy 18.
rEASR92ea83048187: Change `/r/p/` to `/r/` for gerrit links
rEASRd1c09eaa919c: Change `/r/p/` to `/r/` for gerrit links
T218487: Proposal: Improving documentation of ~20 top 70 most viewed MediaWiki Action API pages on-wiki
- Mentioned Here
- T163242: git-review fails with "The requested URL /changes/ was not found on this server."
What are the exact steps to see that breakage? (Picking a random example, both git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Scribunto.git and git clone https://gerrit.wikimedia.org/r/mediawiki/extensions/Scribunto.git work for me and do clone that repo.)
What are the exact steps to see that breakage? […]
I don't know. Just try following the link?
In https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AdvancedSearch/+/498100/1/docs/settings.md links in a readme have been broken.
As far as I understand this ticket here, it is
- exclusively about Gerrit links.
- exclusively about links that are used to clone a repository.
Neither was the case in patch set 1 of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AdvancedSearch/+/498100/1/docs/settings.md. That was unrelated. However, the patch still makes sense after it was updated with a second patch set.
Note that there are many other Gerrit links that might contain the /r/p/ you are looking for but are not about cloning, but to link to a patch set, a file in a patch set, a dashboard, or something else.
I suggest to not blindly remove p/ wherever it can be found, but make sure you are really touching a clone link and copy-paste the new clone link from the Gerrit UI. For example, it is provided here (click "anonymous http" at the top): https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Wikibase
Yeah. this is about links which will end up in somebody's git config as a git remote URL (so URL used for git clone, git remote add, .gitmodules and such). Sorry, I should have been clearer.
The context is (there's a related task but I'm unable to find it, /r/p/ does not make a great search query) that the Gerrit REST API does not work with /p/, more recent versions of git-review use REST API URLs calculated from the git remote URL when that is a HTTPS URL, and that results in confusing breakage for git-review commands.