Page MenuHomePhabricator
Create Task
Maniphest T218862

acme-chief >0.13 generates wrong metadata for the endpoint used in file based deployment layout
Closed, ResolvedPublic
Actions

Description

For requests like /puppet/v3/file_metadata/acmedata/test_certificate/rsa-2048.key acme-chief is returning bad metadata making puppet to create a directory instead of a file. This has not been detected by our current test suite because /puppet/v3/file_content/acmedata/test_certificate/rsa-2048.key works as expected and the test covering /puppet/v3/file_metadata/acmedata/test_certificate/rsa-2048.key has an expected fail annotation.

This triggered https://wikitech.wikimedia.org/wiki/Incident_documentation/20190321-acmechief

Details

SubjectRepoBranchLines +/-
debian: Add release 0.15 to changelogoperations/software/acme-chiefdebian+6 -0
Release 0.15operations/software/acme-chiefdebian+2 -2
acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}operations/software/acme-chiefdebian+27 -18
Release 0.15operations/software/acme-chiefmaster+2 -2
acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}operations/software/acme-chiefmaster+27 -18
Customize query in gerrit

Related Objects

Event Timeline

Vgutierrez triaged this task as High priority.Mar 21 2019, 10:35 AM
Vgutierrez created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2019, 10:35 AM
gerritbot added a comment.Mar 21 2019, 10:39 AM

Change 498046 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@master] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498046

gerritbot added a project: Patch-For-Review.Mar 21 2019, 10:39 AM
Vgutierrez mentioned this in rOSACd098b33dbd99: acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certna….Mar 21 2019, 10:45 AM
Vgutierrez mentioned this in rOSAC8e2ab7bb5f15: acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certna….Mar 21 2019, 11:25 AM
gerritbot added a comment.Mar 21 2019, 11:29 AM

Change 498046 merged by jenkins-bot:
[operations/software/acme-chief@master] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498046

gerritbot added a comment.Mar 21 2019, 11:36 AM

Change 498053 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@master] Release 0.15

https://gerrit.wikimedia.org/r/498053

gerritbot added a comment.Mar 21 2019, 11:38 AM

Change 498054 had a related patch set uploaded (by Alex Monk; owner: Vgutierrez):
[operations/software/acme-chief@debian] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498054

gerritbot added a comment.Mar 21 2019, 11:38 AM

Change 498055 had a related patch set uploaded (by Alex Monk; owner: Vgutierrez):
[operations/software/acme-chief@debian] Release 0.15

https://gerrit.wikimedia.org/r/498055

gerritbot added a comment.Mar 21 2019, 11:39 AM

Change 498053 merged by jenkins-bot:
[operations/software/acme-chief@master] Release 0.15

https://gerrit.wikimedia.org/r/498053

gerritbot added a comment.Mar 21 2019, 11:39 AM

Change 498054 merged by jenkins-bot:
[operations/software/acme-chief@debian] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498054

Krenair mentioned this in rOSAC56c3413a36e3: acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certna….Mar 21 2019, 11:43 AM
Vgutierrez mentioned this in rOSACb7ab9ab1f47d: Release 0.15.Mar 21 2019, 11:43 AM
Krenair mentioned this in rOSAC27fa56348d4a: Release 0.15.Mar 21 2019, 11:43 AM
gerritbot added a comment.Mar 21 2019, 11:46 AM

Change 498055 merged by Vgutierrez:
[operations/software/acme-chief@debian] Release 0.15

https://gerrit.wikimedia.org/r/498055

gerritbot added a comment.Mar 21 2019, 11:48 AM

Change 498056 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@debian] debian: Add release 0.15 to changelog

https://gerrit.wikimedia.org/r/498056

Vgutierrez mentioned this in rOSAC5e7abf684a13: Release 0.15.Mar 21 2019, 11:49 AM
Vgutierrez mentioned this in rOSAC84f6d3899890: debian: Add release 0.15 to changelog.
gerritbot added a comment.Mar 21 2019, 11:56 AM

Change 498056 merged by jenkins-bot:
[operations/software/acme-chief@debian] debian: Add release 0.15 to changelog

https://gerrit.wikimedia.org/r/498056

Stashbot added a comment.Mar 21 2019, 12:02 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-21T12:02:29Z] <vgutierrez> uploaded acme-chief 0.15 to apt.wikimedia.org (buster) - T218862

Stashbot added a comment.Mar 21 2019, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-21T13:54:18Z] <vgutierrez> disabling puppet in acme-chief clients - T218862

Stashbot added a comment.Mar 21 2019, 1:58 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-21T13:58:12Z] <vgutierrez> update acme-chief to version 0.15 in acmechief1001 - T218862

Stashbot added a comment.Mar 21 2019, 2:11 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-21T14:11:29Z] <vgutierrez> re-enabling puppet in acme-chief clients - T218862

Vgutierrez closed this task as Resolved.Mar 21 2019, 2:43 PM
Vgutierrez removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL