Page MenuHomePhabricator

acme-chief >0.13 generates wrong metadata for the endpoint used in file based deployment layout
Closed, ResolvedPublic

Description

For requests like /puppet/v3/file_metadata/acmedata/test_certificate/rsa-2048.key acme-chief is returning bad metadata making puppet to create a directory instead of a file. This has not been detected by our current test suite because /puppet/v3/file_content/acmedata/test_certificate/rsa-2048.key works as expected and the test covering /puppet/v3/file_metadata/acmedata/test_certificate/rsa-2048.key has an expected fail annotation.

This triggered https://wikitech.wikimedia.org/wiki/Incident_documentation/20190321-acmechief

Details

Related Gerrit Patches:
operations/software/acme-chief : debiandebian: Add release 0.15 to changelog
operations/software/acme-chief : debianRelease 0.15
operations/software/acme-chief : debianacme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}
operations/software/acme-chief : masterRelease 0.15
operations/software/acme-chief : masteracme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

Event Timeline

Vgutierrez triaged this task as High priority.Mar 21 2019, 10:35 AM
Vgutierrez created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2019, 10:35 AM

Change 498046 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@master] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498046

Change 498046 merged by jenkins-bot:
[operations/software/acme-chief@master] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498046

Change 498053 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@master] Release 0.15

https://gerrit.wikimedia.org/r/498053

Change 498054 had a related patch set uploaded (by Alex Monk; owner: Vgutierrez):
[operations/software/acme-chief@debian] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498054

Change 498055 had a related patch set uploaded (by Alex Monk; owner: Vgutierrez):
[operations/software/acme-chief@debian] Release 0.15

https://gerrit.wikimedia.org/r/498055

Change 498053 merged by jenkins-bot:
[operations/software/acme-chief@master] Release 0.15

https://gerrit.wikimedia.org/r/498053

Change 498054 merged by jenkins-bot:
[operations/software/acme-chief@debian] acme-chief-api: Fix file_metadata for /puppet/v3/file_metadata/acmedata/{certname}/{part}

https://gerrit.wikimedia.org/r/498054

Change 498055 merged by Vgutierrez:
[operations/software/acme-chief@debian] Release 0.15

https://gerrit.wikimedia.org/r/498055

Change 498056 had a related patch set uploaded (by Vgutierrez; owner: Vgutierrez):
[operations/software/acme-chief@debian] debian: Add release 0.15 to changelog

https://gerrit.wikimedia.org/r/498056

Change 498056 merged by jenkins-bot:
[operations/software/acme-chief@debian] debian: Add release 0.15 to changelog

https://gerrit.wikimedia.org/r/498056

Mentioned in SAL (#wikimedia-operations) [2019-03-21T12:02:29Z] <vgutierrez> uploaded acme-chief 0.15 to apt.wikimedia.org (buster) - T218862

Mentioned in SAL (#wikimedia-operations) [2019-03-21T13:54:18Z] <vgutierrez> disabling puppet in acme-chief clients - T218862

Mentioned in SAL (#wikimedia-operations) [2019-03-21T13:58:12Z] <vgutierrez> update acme-chief to version 0.15 in acmechief1001 - T218862

Mentioned in SAL (#wikimedia-operations) [2019-03-21T14:11:29Z] <vgutierrez> re-enabling puppet in acme-chief clients - T218862

Vgutierrez closed this task as Resolved.Mar 21 2019, 2:43 PM
Vgutierrez removed a project: Patch-For-Review.