Validate length limits for Schema inputs in the front-end
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	Mar 21 2019, 11:26 AM

Description

T214904: [Story] length limits for Schema inputs requires that the length limits are “validated in the frontend (i.e. in the input) as well”, but that doesn’t seem to be done – right now you’ll only see an error after submitting the overlong data.

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/WikibaseSchema	master	+135 -0	Input length validation for Special:NewSchema
mediawiki/extensions/WikibaseSchema	master	+69 -0	Limit the input length on the Schema text edit form
mediawiki/extensions/WikibaseSchema	master	+126 -7	Special:SLDA: Add client side input length validation

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T214904 [Story] length limits for Schema inputs
		Resolved		hoo	T218867 Validate length limits for Schema inputs in the front-end

Event Timeline

To be honest, I’m not sure what exactly this implies. If we set a maxlength, the browser will discard the extra characters, and if the user doesn’t notice that some of their input is missing, the submit will go through and save incomplete data. Do we want that?

(I think we discussed this in some meeting too, but unfortunately I can’t remember the outcome.)

I think there's a mw lib for this, will investigate.

We can use https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.widgets-method-visibleCodePointLimit for this!

Change 498281 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Special:SLDA: Add client side input length validation

https://gerrit.wikimedia.org/r/498281

gerritbot added a project: Patch-For-Review.Mar 22 2019, 1:01 AM

Patch is up for Special:SetSchemaLabelDescriptionAliases, but editing schema text (action=edit) still missing.

Change 498344 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Limit the input length on the Schema text edit form

https://gerrit.wikimedia.org/r/498344

Turns out I forgot Special:NewSchema… will do next.

Change 498281 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Special:SLDA: Add client side input length validation

https://gerrit.wikimedia.org/r/498281

Change 498344 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Limit the input length on the Schema text edit form

https://gerrit.wikimedia.org/r/498344

moving back to Doing for Special:NewSchema

Lucas_Werkmeister_WMDE added a project: Shape Expressions Sprint 5.Mar 25 2019, 2:08 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 5 board.

• Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:02 PM

Change 498962 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Input length validation for Special:NewSchema

https://gerrit.wikimedia.org/r/498962

hoo moved this task from Doing to Peer Review on the Shape Expressions Sprint 5 board.Mar 25 2019, 6:29 PM

Change 498962 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Input length validation for Special:NewSchema

https://gerrit.wikimedia.org/r/498962

hoo moved this task from Peer Review to Verification on the Shape Expressions Sprint 5 board.Mar 25 2019, 7:03 PM