Page MenuHomePhabricator

Special:AbuseFilter/test has wrong variable names for upload actions
Closed, ResolvedPublic

Description

See for instance https://commons.wikimedia.org/w/index.php?title=Special:AbuseFilter/examine/1200691612. This happens since 1.33-wmf.22, and is caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/445325/. Probably because that patch stayed on gerrit for a long time and the changes to T173889 weren't applied. I still have to determine the impact, but it could be only visual. At any rate, I'm coming with a fix shortly.

Event Timeline

Daimona created this task.Mar 21 2019, 12:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2019, 12:27 PM
Daimona claimed this task.Mar 21 2019, 12:27 PM
Daimona triaged this task as High priority.

Change 498062 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Use 'page' prefix for upload vars

https://gerrit.wikimedia.org/r/498062

Aye, I was right! The prefix 'ARTICLE' wasn't updated to 'page'. The impact is that, in order to test uploads, users have to use article_* vars instead of page_*. Nothing else is affected and no need to backport as these values aren't saved in the DB.

Change 498062 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Use 'page' prefix for upload vars

https://gerrit.wikimedia.org/r/498062

Daimona closed this task as Resolved.Mar 22 2019, 10:33 AM
Daimona removed a project: Patch-For-Review.