Page MenuHomePhabricator
Create Task
Maniphest T218929

Run `git submodule sync` when updating extensions.git clones
Closed, DeclinedPublic
Actions

Description

We're getting failures due to the issues in T218844...

Can we add git submodule sync --recursive into the mix of git clone/checkout/update for the extensions.git repo?

https://git-scm.com/docs/git-submodule

sync [--recursive] [--] [<path>…​]
Synchronizes submodules' remote URL configuration setting to the value specified in .gitmodules. It will only affect those submodules which already have a URL entry in .git/config (that is the case when they are initialized or freshly added). This is useful when submodule URLs change upstream and you need to update your local repositories accordingly.

git submodule sync synchronizes all submodules while git submodule sync -- A synchronizes submodule "A" only.

If --recursive is specified, this command will recurse into the registered submodules, and sync any nested submodules within.

Related Objects
Search...

StatusAssignedTask
 ResolvedDzahnT165620 Upload gerrit package to stretch apt.wm.org repo
 ResolvedDzahnT168562 Reimage gerrit2001 as stretch
 ResolvedDzahnT176532 Gerrit is failing to connect to db on gerrit2001 thus preventing systemd from working
 OpenNoneT195280 New Gerrit UI does not contain copyable Change-Id or parent commit id
 OpenNoneT186406 Polygerrit Outgoing reviews, Incoming reviews and Recently closed headings should be more different from commits
 ResolvedPaladoxT200310 "Included groups" do not appear in New gerrit UI
 OpenNoneT201246 Make a PolyGerrit plugin to welcome new users
 OpenNoneT206453 Big empty space under patch description
 OpenNoneT131968 Outgoing and recently closed reviews that have new comments should be marked as bold just as the incoming reviews
 StalledNoneT103990 Gerrit upload-pack send ALL references causing massive network I/O on common operations
 OpenNoneT210515 context links in diff don't use pointer cursor
 OpenPaladoxT214068 Display Zuul status of jobs for a change on Gerrit UI
 ResolvedPaladoxT214631 Create a plugin that add's recheck as a button to PolyGerrit's ui
 OpenNoneT217174 Deploy multi-site plugin to cobalt and gerrit2001
 OpenNoneT220801 PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+)
 OpenNoneT180297 Allow searching for 'state:active', 'state:read_only', 'state:hidden' via web interface
Restricted Task
 OpenNoneT211139 Convert Gerrit to use H2 as the database
 OpenNoneT223278 "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch
 OpenNoneT200739 Upgrade to Gerrit 2.16.12
 ResolvedPaladoxT218844 Update Gerrit /r/p/ links to /r/
 DeclinedNoneT218929 Run `git submodule sync` when updating extensions.git clones

Event Timeline

Reedy created this task.Mar 21 2019, 7:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2019, 7:00 PM
Reedy renamed this task from Run `git submodule sync` to Run `git submodule sync` when updating extensions.git clones.Mar 21 2019, 7:01 PM
Legoktm added a subscriber: Legoktm.Mar 21 2019, 7:14 PM

CI doesn't use mediawiki/extensions.git?

Paladox moved this task from Bugs & stuff to Local hacks on the Gerrit board.Mar 22 2019, 11:18 PM
hashar closed this task as Declined.Mar 22 2019, 11:48 PM
hashar added a subscriber: hashar.

Nop CI does not use mediawiki/extensions.git . It is unclear to me what the issue is about. Feel free to reopen with more details though :)

Jdforrester-WMF added a comment.Mar 23 2019, 6:57 PM

See IRC discussion. Some of Quibble's repos are randomly still pointing at /r/p/ not /r/ so jobs are fatalling on launch.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL