Page MenuHomePhabricator

Puppet runs failing on tools-sgebastion-07.tools.eqiad.wmflabs
Closed, ResolvedPublic

Description

$ sudo -i puppet agent -tv
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, 'lookup' expects one of:
  (NameType = Variant[String, Array[String]] name, ValueType = Type value_type?, MergeType = Variant[String[1, default], Hash[String, Scalar]] merge?)
    rejected: parameter 'value_type' expects a ValueType = Type value, got Boolean
  (NameType = Variant[String, Array[String]] name, Optional[ValueType] value_type, Optional[MergeType] merge, DefaultValueType = Any default_value)
    rejected: expects 4 arguments, got 2
  (NameType = Variant[String, Array[String]] name, ValueType = Type value_type?, MergeType = Variant[String[1, default], Hash[String, Scalar]] merge?)
    rejected: parameter 'value_type' expects a ValueType = Type value, got Boolean
  (OptionsWithName = Struct[{'name' => NameType = Variant[String, Array[String]], 'value_type' => Optional[ValueType = Type], 'default_value' => DefaultValueType = Any, 'override' => Optional[Hash[String, Any]], 'default_values_hash' => Optional[Hash[String, Any]], 'merge' => Optional[MergeType = Variant[String[1, default], Hash[String, Scalar]]]}] options_hash, BlockType = Callable[NameType = Variant[String, Array[String]]] block?)
    rejected: expects 1 argument, got 2
  (Variant[String, Array[String]] name, OptionsWithoutName = Struct[{'value_type' => Optional[ValueType = Type], 'default_value' => DefaultValueType = Any, 'override' => Optional[Hash[String, Any]], 'default_values_hash' => Optional[Hash[String, Any]], 'merge' => Optional[MergeType = Variant[String[1, default], Hash[String, Scalar]]]}] options_hash, BlockType = Callable[NameType = Variant[String, Array[String]]] block?)
    rejected: parameter 'options_hash' expects an OptionsWithoutName = Struct[{'value_type' => Optional[ValueType = Type], 'default_value' => DefaultValueType = Any, 'override' => Optional[Hash[String, Any]], 'default_values_hash' => Optional[Hash[String, Any]], 'merge' => Optional[MergeType = Variant[String[1, default], Hash[String, Scalar]]]}] value, got Boolean at /etc/puppet/modules/role/manifests/labs/instance.pp:60:9 on node tools-sgebastion-07.tools.eqiad.wmflabs
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

Event Timeline

bd808 created this task.Mar 21 2019, 10:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2019, 10:10 PM
Bstorm added a subscriber: Bstorm.Mar 21 2019, 10:11 PM

I bet that's from T218365

bd808 triaged this task as High priority.Mar 21 2019, 10:16 PM

Our puppetmaster versions are the same, and at material was pulled from modules/standard/manifests/diamond.pp, line 22. Wonder why it would be a problem on the VMs in our module?

Why doesn't this bite production, though? Do they have a custom lookup function?

Got it. Prod is using the hiera function. Lookup has different syntax. Fixing.

Change 498255 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] cloudvps: Fix error in lookup for diamond::remove

https://gerrit.wikimedia.org/r/498255

Change 498255 merged by Bstorm:
[operations/puppet@production] cloudvps: Fix error in lookup for diamond::remove

https://gerrit.wikimedia.org/r/498255

Bstorm closed this task as Resolved.Mar 21 2019, 10:46 PM
Bstorm claimed this task.

Puppet runs ok again.