Page MenuHomePhabricator

Native controls shown for number inputs in Firefox
Closed, ResolvedPublic

Description

Since recently (I rather suspect the update to FF 66 than an OOUI update), number inputs show the native controls in Firefox:


They should be hidden again, like in other browsers.

Event Timeline

.oo-ui-textInputWidget .oo-ui-inputWidget-input {
    -webkit-appearance: none;
}

overrides

.oo-ui-textInputWidget [type="number"] {
    -moz-appearance: textfield;
}
Volker_E triaged this task as Medium priority.Mar 25 2019, 4:06 AM

Change 498758 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] TextInputWidget: Remove proprietary vendor UI extensions

https://gerrit.wikimedia.org/r/498758

Thanks @Schnark! Darn it vendor properties…

Volker_E edited projects, added OOUI (OOUI-0.31.2); removed OOUI.

Change 498758 merged by jenkins-bot:
[oojs/ui@master] TextInputWidget: Remove proprietary vendor UI extensions

https://gerrit.wikimedia.org/r/498758

Volker_E claimed this task.
Volker_E removed a project: Patch-For-Review.

Change 499353 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.2

https://gerrit.wikimedia.org/r/499353

Change 499353 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.2

https://gerrit.wikimedia.org/r/499353

Jdforrester-WMF added a subscriber: Jdforrester-WMF.

This patch landed in MediaWiki master in time for 1.33.0-wmf.24, which will go out to Wikimedia production from 2019-04-02.

Volker_E moved this task from OOUI-0.31.2 to Backlog on the OOUI board.
Volker_E edited projects, added OOUI; removed OOUI (OOUI-0.31.2).

To hell with vendor properties. While Firefox/macOS is cured with latest patch and relies on -webkit-appearance: none, Firefox/Windows expects -moz-appearance: textfield. Master on demos still shows this.
We can decide which of the lesser evils we chose from…
`

Change 516811 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] TextInputWidget: Fix Firefox proprietary appearance

https://gerrit.wikimedia.org/r/516811

Note: moz-appearance: none is not removing the steppers on Firefox/macOS.

Change 516811 merged by jenkins-bot:
[oojs/ui@master] TextInputWidget: Fix Firefox proprietary appearance

https://gerrit.wikimedia.org/r/516811

Volker_E claimed this task.
Volker_E moved this task from Backlog to OOUI-0.33.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.33.0); removed OOUI.

Fingers crossed.

Change 519341 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

Change 519341 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.33.0

https://gerrit.wikimedia.org/r/519341

This feature change has landed in MediaWiki 1.34.0-wmf.13.