| kostajh | |
| Mar 22 2019, 7:06 PM |
| F37145870: Screen Shot 2023-07-21 at 1.30.29 PM.png | |
| Jul 21 2023, 8:35 PM |
| F37145868: Screen Shot 2023-07-21 at 1.31.03 PM.png | |
| Jul 21 2023, 8:35 PM |
| F35538442: image.png | |
| Sep 28 2022, 7:51 PM |
Following up from T217281, this is a feature request to allow transcluding Special:Impact on wikitext pages with {{Special:Impact/username}}
Notes on implementation:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T316699 [EPIC] Growth: Positive reinforcement - Iteration 2 | |||
| Resolved | Feature | Sgs | T219025 Impact Module Extensibility: allow transcluding Special:Impact on wikitext pages with {{Special:Impact/username}} |
Removing T222310 as parent tasks since it was decided that client rendering will make this task too complex to include it as an extensibility goal for the new impact module / positive reinforcement work.
It seems to mostly "just work":
The relevant code is setting isIncludable() { return true; } on SpecialImpact.php.
usages of "your", "you", "you've", etc need to be replaced so it's clear the impact data is for the user that it's rendered for
One easy way to fix this is to just remove "Your" from the strings in all scenarios, so "Your impact" becomes "Impact", and "Your recent activity" becomes "Recent activity". That has the benefit of working better for smaller screens, too.
We'd need to update the stats on page load using JS, as otherwise they are valid as of the time the special page was transcluded
We are always fetching and rendering data via the client-side, so this isn't a concern like it was with the older Impact module where we server-side rendered the content.
@KStoller-WMF I'm moving this to Triaged, but if you want the one-line patch to allow users to embed {{Special:Impact/SomeUser}}, we can do that very easily.
Exciting, thanks for letting me know that this is relatively low effort! Let's get the initial version out before we tackle that work, but I definitely want to consider this for the second iteration!
Change 878179 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: allow to transclude Special:Impact/username
I believe the primary use case is someone who wants to embed the impact module on their userpage, to highlight their impact data to others.
Change 935437 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] User impact: increase request rate limits for impact data
Change 935437 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] User impact: increase request rate limits for impact data
Change 878179 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] User impact: allow to transclude Special:Impact/<username>
Checked on testwiki wmf.18 - the "your" and "you" etc have been removed for transcluded Impact module as per the following requirement:
usages of "your", "you", "you've", etc need to be replaced so it's clear the impact data is for the user that it's rendered for
| Impact module on Homepage | Transcluded on User page |
|---|---|
 |  |