Description
The AMC toggle takes two taps to turn off/on
Details
Browser & device: iOS/Safari & Chrome, Android/Chome
QA Results
Status | Details |
✅ Passed | T219028#5071323 |
• alexhollender_WMF | |
Mar 22 2019, 7:41 PM |
F28513438: ScreenRecording_03-29-2019 16-44-24.MP4 | |
Mar 29 2019, 11:45 PM |
F28445790: two tries for on off.mov | |
Mar 22 2019, 7:41 PM |
The AMC toggle takes two taps to turn off/on
Browser & device: iOS/Safari & Chrome, Android/Chome
Status | Details |
✅ Passed | T219028#5071323 |
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Update user preferences before flusing output. | mediawiki/extensions/MobileFrontend | master | +2 -2 |
I'll look into that, user preferences update happens as a deferred update (it's executed as a last thing during page request). Same happens with the Beta switch. I think that can happen when prod is bit overloaded, and server renders you a new page, but the properties update didn't finish yet. Thats why it renders as "off" state (because switching to ON is still in progress).
I'll update the code to update the database before it returns any content to the user.
Change 498943 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] Update user preferences before flusing output.
Change 498943 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update user preferences before flusing output.
Status: ✅ PASS
OS: iOS
Browser: Chrome on (iPhone XS Max)
Test Artifact(s):