Maniphest T219033

Syntax error in OOUI documentations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Huji
	Mar 22 2019, 8:27 PM

Description

On https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.MenuLayout the example code provided contains a syntax error; if you try the live preview you will get this: SyntaxError: missing ) after argument list

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+403 -355	Update OOUI to v0.31.3
	oojs/ui	master	+2 -2	docs: Fix syntax errors in MenuLayout

Customize query in gerrit

Event Timeline

Huji created this task.Mar 22 2019, 8:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2019, 8:27 PM

To fix it, you need to remove two semicolons. I have shown where it is below:

...
menuLayout.$menu.append(
    menuPanel.$element.append( '<b>Menu panel</b>', select.$element );   <=  THIS SEMICOLON
);
menuLayout.$content.append(
    contentPanel.$element.append(
        '<b>Content panel</b>',
        '<p>Note that the menu is positioned relative to the content panel: ' +
        'top, bottom, after, before.</p>'
     );   <=    THIS ONE TOO
);
...

xSavitar added a project: Africa-Wikimedia-Developers.Mar 23 2019, 11:02 AM

xSavitar moved this task from Backlog to New Contributor's Tasks (Incoming) on the Africa-Wikimedia-Developers board.

Mahveotm claimed this task.Mar 23 2019, 11:31 AM

Didicodes added a subscriber: Didicodes.Mar 23 2019, 3:16 PM

xSavitar moved this task from New Contributor's Tasks (Incoming) to Tasks in progress (Doing) on the Africa-Wikimedia-Developers board.Mar 24 2019, 3:21 PM

Volker_E triaged this task as Low priority.Mar 28 2019, 3:28 AM

Change 501126 had a related patch set uploaded (by Huji; owner: Huji):
[oojs/ui@master] Fix syntax error in OOUI documentations

https://gerrit.wikimedia.org/r/501126

gerritbot added a project: Patch-For-Review.Apr 4 2019, 1:45 AM

It bothers me a lot, so I'm posting a fix.

Volker_E moved this task from Backlog to OOUI-0.31.3 on the OOUI board.Apr 4 2019, 2:13 AM

Volker_E edited projects, added OOUI (OOUI-0.31.3); removed OOUI.

Change 501126 merged by jenkins-bot:
[oojs/ui@master] docs: Fix syntax errors in MenuLayout

https://gerrit.wikimedia.org/r/501126

Huji closed this task as Resolved.Apr 4 2019, 2:28 AM

Huji removed projects: Patch-For-Review, good first task.

Huji removed a project: Africa-Wikimedia-Developers.

Change 501429 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.31.3

https://gerrit.wikimedia.org/r/501429

gerritbot added a project: Patch-For-Review.Apr 4 2019, 9:42 PM

Change 501429 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.3

https://gerrit.wikimedia.org/r/501429

Jdforrester-WMF removed a project: Patch-For-Review.Apr 5 2019, 6:20 PM

Syntax error in OOUI documentationsClosed, ResolvedPublicActions

Description

Details

Event Timeline

Syntax error in OOUI documentations
Closed, ResolvedPublic
Actions