Page MenuHomePhabricator

Sysop undeletion removes revision deletion restrictions
Closed, ResolvedPublic

Description

Author: mike.lifeguard+bugs

Description:
Here, some revision deletion (suppression) was done, then the page was undeleted, which removed all those restrictions, and they were placed again. If a sysop can't modify the visibility on an individual revision, they can't be allowed to sidetrack it by nuking all restrictions by undeleting the whole page.


Version: 1.16.x
Severity: major
URL: http://nl.wikipedia.org/w/index.php?title=Speciaal:Terugplaatsen&target=Gebruiker%3ALKD+ist+eine+miese+Sau!

Details

Reference
bz19905

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:42 PM
bzimport set Reference to bz19905.

Afaics that case just happens when it's the only revision of the entire article. Just when then that single revision gets deleted, hidden and restored it will lose all restrictions. It might not happen quite often, but happened and is not unrealistic.

Kind regards
DerHexer

aaron added a comment.Jul 24 2009, 7:07 AM

(In reply to comment #1)

Afaics that case just happens when it's the only revision of the entire
article. Just when then that single revision gets deleted, hidden and restored
it will lose all restrictions. It might not happen quite often, but happened
and is not unrealistic.
Kind regards
DerHexer

Trying to restore a one-rev suppressed page just gives me a permission error if I don't have the rights.

If a user does have the oversight permissions, restoring a page will always clear restrictions on the very top revision. Otherwise, things would break or it would have to just give a restoration error and do nothing.

Hmm, Wutsje (a nl.wp sysop who's not a steward/oversight) was able to restore it. I've tested it on test.wp recently: If a sysop restores just hidden revisions of an entirely deleted page, one revision at least gets unhidden (because of the reason you mentioned: a public article cannot just contain hidden revisions).

Was the edit suppressed or was just regular revisiondelete used?

(In reply to comment #4)

Was the edit suppressed or was just regular revisiondelete used?

Nevermind...I see the issue, I was testing the wrong code branch

Fixed in r53715

Already synced