Page MenuHomePhabricator
Create Task
Maniphest T219084

[Beta Cluster] "Targets passed" entry not created until one edit after the target is met
Closed, ResolvedPublicBUG REPORT
Actions

Description

The targets passed entry should be created immediately after a target count is met, but on the Beta Cluster, is not created until after the next edit.

Steps to Reproduce: Make five qualifying edits, check the wikimedia_editor_tasks_targets_passed table, then make a sixth and check it again.

Expected Results: The targets_passed entry is populated immediately after the fifth edit.

Actual Results: The targets_passed entry is populated immediately after the sixth edit.

(Note: Bug does not occur in a local MW-Vagrant environment.)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikimediaEditorTasksmaster+12 -4Fix: Use READ_LOCKING when evaluating whether to update targets_passed
mediawiki/extensions/WikimediaEditorTaskswmf/1.33.0-wmf.23+12 -4Fix: Use READ_LOCKING when evaluating whether to update targets_passed
Customize query in gerrit

Related Objects

Event Timeline

• Mholloway created this task.Mar 23 2019, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 23 2019, 10:11 PM
• Mholloway updated the task description. (Show Details)Mar 23 2019, 10:24 PM
• Mholloway updated the task description. (Show Details)Mar 24 2019, 4:10 AM
• Mholloway claimed this task.Mar 25 2019, 1:38 PM
• Mholloway moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.
• Mholloway moved this task from Doing to Blocked on the Product-Infrastructure-Team-Backlog (Kanban) board.Mar 25 2019, 4:44 PM

Blocked on T219180.

• Mholloway moved this task from Blocked to Doing on the Product-Infrastructure-Team-Backlog (Kanban) board.Mar 25 2019, 4:50 PM
• Mholloway added a subscriber: • Tgr.Mar 25 2019, 5:27 PM

@Tgr Any idea offhand what could be going on here? I can't even come up with a good theory.

• Mholloway added a comment.Mar 25 2019, 6:22 PM

Seems like there is a race between the db replicas getting the incremented value and the PHP code reading from a replica to get the updated value. Might have to update to read from master to evaluate targets passed after incrementing.

• Mholloway added a comment.Mar 25 2019, 6:30 PM

Confirmed that this ^ is what's happening. Reading from DB_MASTER in the follow-up query fixes the issue.

gerritbot added a comment.Mar 25 2019, 6:36 PM

Change 498963 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/WikimediaEditorTasks@master] Fix: Read counts from DB_MASTER when updating targets_passed

https://gerrit.wikimedia.org/r/498963

gerritbot added a project: Patch-For-Review.Mar 25 2019, 6:36 PM
• Mholloway moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog (Kanban) board.Mar 25 2019, 6:36 PM
• Mholloway mentioned this in rEWETbaffd4d51b6f: Fix: Read counts from DB_MASTER when updating targets_passed.Mar 25 2019, 6:39 PM
• Mholloway mentioned this in rEWET7b5af40e3155: Fix: Use READ_LOCKING when evaluating whether to update targets_passed.Mar 25 2019, 9:49 PM
• Mholloway mentioned this in rEWET851e45c200b4: Fix: Use READ_LOCKING when evaluating whether to update targets_passed.Mar 27 2019, 1:31 PM
gerritbot added a comment.Mar 27 2019, 4:29 PM

Change 498963 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEditorTasks@master] Fix: Use READ_LOCKING when evaluating whether to update targets_passed

https://gerrit.wikimedia.org/r/498963

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 5:00 PM
gerritbot added a comment.Mar 27 2019, 5:17 PM

Change 499544 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.33.0-wmf.23] Fix: Use READ_LOCKING when evaluating whether to update targets_passed

https://gerrit.wikimedia.org/r/499544

• Mholloway mentioned this in rEWET3d97d35ae784: Fix: Use READ_LOCKING when evaluating whether to update targets_passed.Mar 27 2019, 5:24 PM
gerritbot added a comment.Mar 27 2019, 8:09 PM

Change 499544 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEditorTasks@wmf/1.33.0-wmf.23] Fix: Use READ_LOCKING when evaluating whether to update targets_passed

https://gerrit.wikimedia.org/r/499544

• Mholloway closed this task as Resolved.Mar 27 2019, 8:39 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 9:01 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL