Page MenuHomePhabricator
Create Task
Maniphest T219127

SRE FY19-20 Q1 goal: complete the transition to PHP7
Closed, ResolvedPublic
Actions

Description

The SRE serviceops team wants to conclude T176370, the migration to php 7.x, by the end of June 2019. This will mean a series of subgoals will need to be carried out:

  • Remove php7 beta feature, move logged-in users to use the extracted cookie as well.
  • Allow directing a percentage traffic to the api cluster to php7
  • Use php7 to run maintenance scripts
  • Ramp up percentage of users on php7.2 to 100% on both API and appserver clusters
  • Use php7 for processing async jobs
  • Remove hhvm from production (stretch) T229792

This goal the continuance of FY18-19 Q4

Details

SubjectRepoBranchLines +/-
Remove bogus $wgWMEPhp7SamplingRate settingoperations/mediawiki-configmaster+0 -3
Remove the cookie extraction for sending users to PHP7mediawiki/extensions/WikimediaEventsmaster+3 -54
lvs: do not check hhvm/php7 at the same time anymore.operations/puppetproduction+0 -12
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedjijikiT219127 SRE FY19-20 Q1 goal: complete the transition to PHP7
 ResolvedjijikiT219148 Use PHP7 to run all async jobs
 ResolvedNoneT219150 Ramp up percentage of users on php7.2 to 100% on both API and appserver clusters
 ResolvedjijikiT219129 Allow directing a percentage of API traffic to PHP7
 ResolvedNoneT219128 Remove php7 beta feature
 ResolvedNoneT222705 Improve Pybal's url checks
 InvalidjijikiT228643 Don't monitor HHVM on PHP7 only servers
 ResolvedNoneT195392 Switch cronjobs on maintenance hosts to PHP7
 ResolvedNoneT195393 Run all maintenance scripts on PHP7 or HHVM
 ResolvedDzahnT192092 setup replacements for maintenance_server (terbium, wasat) on Stretch
 ResolvedRobHT192185 request to assign spare systems as terbium equivalent
 Resolved• CmjohnsonT193798 change hostname label for mw1297 to mwmaint1001
 ResolvedMoritzMuehlenhoffT193915 rename wasat to mwmaint2001 and reinstall it with stretch
 ResolvedPapaulT199530 Rename of wasat to mwmaint2001 (switch labels et al)
 ResolvedSmalyshevT204389 Update wasat/mwmaint2001 docs on Wikitech
 ResolvedjcrespoT193919 provide proxysql for stretch, add package to puppet
 ResolvedJdforrester-WMFT198805 Update wikitech docs to use new mwmaint1001 instead of terbium
 ResolvedNoneT222900 Separate Wikitech cronjobs from production
 ResolvedDzahnT230110 Stop forcing RUNNER=php for foreachwiki/foreachwikiindblist
 ResolvedPRODUCTION ERRORReedyT216664 MWException when viewing or comparing certain pages with Preprocessor_DOM (PHP7 beta feature)
 DuplicatePRODUCTION ERRORNoneT218005 Variable from InitialiseSettings can be undefined (corrupt opcache?)
ResolvedKrinkleT215746 Checkup on cssjanus PHP 7 compat
 ResolvedPRODUCTION ERRORJoeT221347 PHP7 opcache sometimes corrupts when cleared (was: Fatal ConfigException, undefined InitialiseSettings variable)
 DuplicateNoneT218615 Switch wikitech to php7
 ResolvedDzahnT219157 labweb1001: mwscript php7.2: command not found
 ResolvedAndrewT223393 switch wikitech to PHP 7.2
 ResolvedjijikiT229792 Remove HHVM from production
 ResolvedawightT236019 Remove HHVM support from Quibble
 ResolvedjijikiT239054 Reimage all mediawiki servers
ResolvedjijikiT234283 Messages in Logstash from php-fatal-error.php are missing from type:mediawiki/channel:fatal

Event Timeline

Joe created this task.Mar 25 2019, 10:28 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2019, 10:28 AM
Joe triaged this task as Medium priority.Mar 25 2019, 10:29 AM
Joe added projects: serviceops, SRE.
Joe updated the task description. (Show Details)
Lucas_Werkmeister_WMDE subscribed.Mar 25 2019, 12:49 PM
jijiki subscribed.Mar 26 2019, 3:36 PM
Krinkle added a subtask: T195392: Switch cronjobs on maintenance hosts to PHP7.Mar 26 2019, 4:34 PM
jijiki removed a subtask: T219129: Allow directing a percentage of API traffic to PHP7.Apr 5 2019, 3:14 PM
jijiki removed a subtask: T219128: Remove php7 beta feature.
Joe added a subtask: T216664: MWException when viewing or comparing certain pages with Preprocessor_DOM (PHP7 beta feature).May 8 2019, 12:41 PM
Paladox subscribed.May 8 2019, 12:42 PM
Joe added a subtask: T218005: Variable from InitialiseSettings can be undefined (corrupt opcache?) .May 8 2019, 12:46 PM
Joe added a subtask: T219901: Default to Preprocessor_Hash for PHP 7.May 8 2019, 12:49 PM
Joe added a subtask: T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.
Joe added a subtask: T215746: Checkup on cssjanus PHP 7 compat.
Krinkle added a subtask: T221347: PHP7 opcache sometimes corrupts when cleared (was: Fatal ConfigException, undefined InitialiseSettings variable).May 8 2019, 2:00 PM
Krinkle removed a subtask: T219901: Default to Preprocessor_Hash for PHP 7.May 8 2019, 2:20 PM
Reedy closed subtask T216664: MWException when viewing or comparing certain pages with Preprocessor_DOM (PHP7 beta feature) as Resolved.May 10 2019, 3:38 PM
Reedy closed subtask T215746: Checkup on cssjanus PHP 7 compat as Resolved.May 11 2019, 1:20 AM
Reedy updated the task description. (Show Details)May 14 2019, 5:11 PM
Joe mentioned this in T219128: Remove php7 beta feature.May 15 2019, 9:33 AM
Jdforrester-WMF removed a subtask: T219135: Use PHP7 to run maintenance scripts.May 15 2019, 7:09 PM
Jdforrester-WMF added a subtask: T218615: Switch wikitech to php7.May 15 2019, 7:11 PM
Dzahn added a subtask: T223393: switch wikitech to PHP 7.2.May 15 2019, 7:12 PM
Jdforrester-WMF updated the task description. (Show Details)May 15 2019, 7:12 PM
Joe closed subtask T221347: PHP7 opcache sometimes corrupts when cleared (was: Fatal ConfigException, undefined InitialiseSettings variable) as Resolved.May 22 2019, 6:10 AM
Michael subscribed.May 22 2019, 9:08 AM
Krinkle changed the status of subtask T221347: PHP7 opcache sometimes corrupts when cleared (was: Fatal ConfigException, undefined InitialiseSettings variable) from Duplicate to Resolved.May 29 2019, 3:57 PM
RazeSoldier subscribed.Jun 1 2019, 3:59 AM
• fsero moved this task from Incoming 🐫 to Unused 3 on the serviceops board.Jun 20 2019, 2:17 PM
akosiaris moved this task from Unused 3 to Incoming 🐫 on the serviceops board.Jun 21 2019, 8:26 AM
akosiaris moved this task from Incoming 🐫 to API Gateway 🥌 on the serviceops board.Jun 21 2019, 8:58 AM
Joe moved this task from API Gateway 🥌 to Incoming 🐫 on the serviceops board.Jun 21 2019, 9:37 AM
jijiki moved this task from Incoming 🐫 to 🗄 Projects on the serviceops board.Jul 5 2019, 10:18 AM
Fito updated the task description. (Show Details)Jul 17 2019, 9:34 PM
jijiki renamed this task from SRE FY2019 Q4 goal: complete the transition to PHP7 to SRE FY19-20 Q1 goal: complete the transition to PHP7.Jul 22 2019, 10:13 AM
jijiki updated the task description. (Show Details)
jijiki updated the task description. (Show Details)Jul 26 2019, 10:28 AM
jijiki added a subtask: T229792: Remove HHVM from production.Aug 5 2019, 9:56 AM
jijiki closed subtask T219148: Use PHP7 to run all async jobs as Resolved.Aug 5 2019, 2:29 PM
Masumrezarock100 subscribed.Aug 18 2019, 6:26 AM
jijiki closed subtask T195392: Switch cronjobs on maintenance hosts to PHP7 as Resolved.Sep 13 2019, 5:44 AM
Ricordisamoa subscribed.Sep 21 2019, 5:54 AM
Joe updated the task description. (Show Details)Sep 24 2019, 11:33 AM
gerritbot added a comment.Sep 24 2019, 11:34 AM

Change 538864 had a related patch set uploaded (by Giuseppe Lavagetto; owner: Giuseppe Lavagetto):
[operations/puppet@production] lvs: do not check hhvm/php7 at the same time anymore.

https://gerrit.wikimedia.org/r/538864

gerritbot added a project: Patch-For-Review.Sep 24 2019, 11:34 AM
gerritbot added a comment.Sep 25 2019, 6:28 AM

Change 538864 merged by Giuseppe Lavagetto:
[operations/puppet@production] lvs: do not check hhvm/php7 at the same time anymore.

https://gerrit.wikimedia.org/r/538864

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2019, 7:10 AM
Joe closed subtask T219150: Ramp up percentage of users on php7.2 to 100% on both API and appserver clusters as Resolved.Sep 25 2019, 7:12 AM
gerritbot added a comment.Oct 4 2019, 12:20 AM

Change 539128 had a related patch set uploaded (by Krinkle; owner: Giuseppe Lavagetto):
[mediawiki/extensions/WikimediaEvents@master] Remove the cookie extraction for sending users to PHP7

https://gerrit.wikimedia.org/r/539128

gerritbot added a project: Patch-For-Review.Oct 4 2019, 12:20 AM
Dzahn closed subtask T223393: switch wikitech to PHP 7.2 as Resolved.Oct 9 2019, 11:39 PM
Krinkle added a subtask: T234283: Messages in Logstash from php-fatal-error.php are missing from type:mediawiki/channel:fatal.Oct 10 2019, 10:44 PM
Krinkle removed a subtask: T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.Oct 11 2019, 6:01 PM
gerritbot added a comment.Oct 17 2019, 3:06 AM

Change 539128 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Remove the cookie extraction for sending users to PHP7

https://gerrit.wikimedia.org/r/539128

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2019, 3:11 AM
jijiki closed this task as Resolved.Oct 25 2019, 6:23 AM
jijiki claimed this task.
jijiki updated the task description. (Show Details)

I believe this is done:)
Removing HHVM is continuing under T229792

Krinkle closed subtask T234283: Messages in Logstash from php-fatal-error.php are missing from type:mediawiki/channel:fatal as Resolved.Nov 7 2019, 6:43 PM
jijiki closed subtask T229792: Remove HHVM from production as Resolved.Jan 5 2020, 8:45 PM
gerritbot added a comment.Jul 3 2020, 9:03 PM

Change 609494 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[operations/mediawiki-config@master] Remove bogus $wgWMEPhp7SamplingRate setting

https://gerrit.wikimedia.org/r/609494

gerritbot added a project: Patch-For-Review.Jul 3 2020, 9:03 PM
gerritbot added a comment.Aug 12 2020, 3:59 PM

Change 609494 merged by jenkins-bot:
[operations/mediawiki-config@master] Remove bogus $wgWMEPhp7SamplingRate setting

https://gerrit.wikimedia.org/r/609494

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL