Page MenuHomePhabricator
Create Task
Maniphest T219143

Write DDL sql files for creating the schema
Closed, ResolvedPublic
Actions

Description

  • use integers for entity ids
  • find better naming for the tables

image.png (562×598 px, 59 KB)
source: https://commons.wikimedia.org/wiki/File:Wikibase_Terms_Store_Schema.png

Details

SubjectRepoBranchLines +/-
Add DDL for new schema of normalized wb_termsmediawiki/extensions/Wikibasemaster+126 -0
Add wb_terms replacement tablesmediawiki/extensions/Wikibasemaster+33 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alaa_wmde created this task.Mar 25 2019, 12:32 PM
• alaa_wmde removed a subtask: T219144: wbterms: Register new terms store schema changes with MW update mechanism.Mar 25 2019, 12:34 PM
• alaa_wmde moved this task from Backlog to Checkpoint Backlog [Create the Schema] on the Wikidata wb_terms Trailblazing board.
• alaa_wmde updated the task description. (Show Details)Mar 25 2019, 12:37 PM
• alaa_wmde moved this task from Checkpoint Backlog [Create the Schema] to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.
• alaa_wmde updated the task description. (Show Details)Mar 25 2019, 1:05 PM
• alaa_wmde moved this task from Ready to go [prioritized] to Stalled on the Wikidata wb_terms Trailblazing board.Mar 25 2019, 1:42 PM
• alaa_wmde moved this task from Stalled to In Progress on the Wikidata wb_terms Trailblazing board.
gerritbot added a comment.Mar 25 2019, 3:20 PM

Change 498869 had a related patch set uploaded (by Alaa Sarhan; owner: Jeroen De Dauw):
[mediawiki/extensions/Wikibase@master] Add wb_terms replacement tables

https://gerrit.wikimedia.org/r/498869

gerritbot added a project: Patch-For-Review.Mar 25 2019, 3:20 PM
Lydia_Pintscher added a project: Wikidata.Mar 25 2019, 3:57 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 4:00 PM
gerritbot added a comment.Mar 26 2019, 8:52 AM

Change 499142 had a related patch set uploaded (by Alaa Sarhan; owner: Jeroen De Dauw):
[mediawiki/extensions/Wikibase@master] Add DDL for new schema of normalized wb_terms.

https://gerrit.wikimedia.org/r/499142

gerritbot added a comment.Mar 26 2019, 8:57 AM

Change 498869 abandoned by Alaa Sarhan:
Add wb_terms replacement tables

Reason:
Follow on 499142

https://gerrit.wikimedia.org/r/498869

• alaa_wmde updated the task description. (Show Details)Mar 26 2019, 8:58 AM
• alaa_wmde updated the task description. (Show Details)
• alaa_wmde moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.Mar 27 2019, 9:05 AM
• alaa_wmde claimed this task.Mar 27 2019, 9:26 AM
• alaa_wmde added subscribers: • Marostegui, jcrespo.Apr 1 2019, 1:19 PM
• alaa_wmde moved this task from In Review to Done on the Wikidata wb_terms Trailblazing board.Apr 4 2019, 9:25 PM
• alaa_wmde mentioned this in T220157: Update schema in wikibase-term-store to match original schema.
• alaa_wmde moved this task from Done to In Progress on the Wikidata wb_terms Trailblazing board.Apr 5 2019, 1:21 PM
• alaa_wmde moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.Apr 5 2019, 1:54 PM
• alaa_wmde added a subscriber: Ladsgroup.Apr 5 2019, 2:54 PM

@Ladsgroup I added the covering indexes on all tables with main field as first index and foreign key as the second to serve the joins.. not sure if we want the reverse order too as covering index so I didn't do it yet

• alaa_wmde added a comment.Apr 8 2019, 8:54 AM

@Ladsgroup I just realized that the covering index should actually have the join column first, right?

Ladsgroup added a comment.Apr 8 2019, 9:00 AM
In T219143#5092297, @alaa_wmde wrote:

@Ladsgroup I just realized that the covering index should actually have the join column first, right?

Yes, that's true!

• alaa_wmde added a comment.Apr 8 2019, 9:00 AM

Okay will update the patch then

gerritbot added a comment.Apr 17 2019, 10:01 AM

Change 499142 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add DDL for new schema of normalized wb_terms

https://gerrit.wikimedia.org/r/499142

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 17 2019, 11:00 AM
• alaa_wmde moved this task from In Review to Done on the Wikidata wb_terms Trailblazing board.Apr 23 2019, 7:26 AM
• alaa_wmde updated the task description. (Show Details)Apr 23 2019, 8:45 PM
• alaa_wmde closed this task as Resolved.May 22 2019, 10:27 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL