Page MenuHomePhabricator
Create Task
Maniphest T219158

'IP visibility' and 'Terms of use' information on termbox editing
Open, Needs TriagePublic
Actions

Description

As as user
I want to be informed about the way my the information I contribute is used
so that I can participate in the open data movement with confidence

Current termbox (v1) implemetatation, as well as other wikidata editing features, shows an overlay (in-page "popup") regarding 'IP visibility' (yellow) when editing without being logged in.
Editing forms for some other entity features (e.g. Statements) also show a popup regarding 'Terms of use'/License (white) when entering the edit mode.

Bildschirmfoto von 2019-03-25 14-57-23.png (1×1 px, 248 KB)

From a brief chat with @Lydia_Pintscher I took away that these are hard requirements for a termbox use in production. Are there upcoming stories for this already, @Lea_WMDE

Note Neither of the two bubbles is blocking, i.e. the user never has to interact with them to perform a change

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT219158 'IP visibility' and 'Terms of use' information on termbox editing
 Resolved• Hanna_Petruschat_WMDET221831 Add "You are not logged in" overlay popup on termbox editing
 Resolved• Matthias_Geisler_WMDET222692 research links, where do the urls come from (incl `returnto` params)
 Resolved• Matthias_Geisler_WMDET222695 Create buttons
 Resolved• Pablo-WMDET222696 Show overlay when entering edit mode
 ResolvedJakob_WMDET222697 Implement generic overlay capability
 ResolvedNoneT222698 Implement IP warning overlay
 Resolved• Pablo-WMDET223437 Make work at 320px width
 Resolved• Pablo-WMDET223542 Focus modal CTAs instead of publish button
 ResolvedJakob_WMDET224548 Make (yellow) warning background wider than rest of content
 ResolvedLea_WMDET221833 Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice
 Resolved• Matthias_Geisler_WMDET223982 Create custom checkbox component
 Resolved• Pablo-WMDET223985 Use checkbox in AnonEditWarning
 ResolvedJakob_WMDET223986 Create user preference repository
 ResolvedJakob_WMDET223987 Use user preference value to avoid "You are not logged in" overlay
 Resolved• Matthias_Geisler_WMDET224540 Polish checkbox
 Resolved• Pablo-WMDET224976 Browser test persistence
 Resolved• Pablo-WMDET221835 Add CC0 License overlay popup on termbox editing
 Resolved• Matthias_Geisler_WMDET224489 Implement License Overlay
 Resolved• Matthias_Geisler_WMDET224490 Use overlay when clicking save on termbox
 Resolved• Matthias_Geisler_WMDET225208 Create browser test for the license overlay
 ResolvedLea_WMDET221836 Add the "I accept these terms for my future edits" checkbox to License popup on mobile termbox editing, and remember the choice
 ResolvedJakob_WMDET225502 Create AxiosUserPreferenceRepository
 ResolvedJakob_WMDET225507 Create delegating preference repository
 OpenNoneT225508 Create browser test for the persistence of the license overlay checkbox state
 OpenNoneT225509 Wire up license warning checkbox

Event Timeline

• Pablo-WMDE created this task.Mar 25 2019, 2:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2019, 2:05 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 3:59 PM
• Pablo-WMDE updated the task description. (Show Details)Mar 27 2019, 1:33 PM
Lea_WMDE moved this task from Backlog to MVP tickets: In preparation on the Wikidata-Termbox board.Mar 28 2019, 3:53 PM
• Pablo-WMDE added a subscriber: • Hanna_Petruschat_WMDE.Apr 10 2019, 2:46 PM

@Hanna_Petruschat_WMDE
Random observation: the wikipedia site link section has some in-component messaging about "terms of use" which could act as inspiration / guidance for consistency.

Bildschirmfoto von 2019-04-10 16-39-09.png (1×1 px, 275 KB)

• Pablo-WMDE updated the task description. (Show Details)Apr 18 2019, 2:05 PM
WMDE-leszek subscribed.EditedApr 24 2019, 2:48 PM

Notes from the session 2019-04-24:

  • Desktop styling/appearance of the "popups" is to be defined in the separate story: T221779
  • Log in popup cannot be "clicked away" without making a decision
  • Log in/Sign up links open the relevant page in the same tab, after performing the action requested, the user comes back to item page they were on before
  • IP address popup: Remember my choice checkbox tracked separately as T221833
  • possible useful stat: number of clicks on the Cancel of the license
  • both logged in users and anon users should be presented with the CC0 information (unless already chosen to never show it)
  • Log in "window" shows up when clicked Edit button, the "license window" appears when clicking the publish button
  • persisting the state of choice: non-logged in users via "cookie", logged in users - state attached to the user account
  • links in the CC0 license popup shall open in the new tab. URLs opened should be in line with what the "old" desktop version of Wikibase uses
WMDE-leszek added a comment.Apr 24 2019, 3:06 PM

Estimate:
Log in pop up, mobile only, no persistence of the choice: 8
Persistence of the choice in the IP address/log in popup: 5

Jakob_WMDE moved this task from MVP tickets: In preparation to MVP things: Ready for pickup on the Wikidata-Termbox board.May 9 2019, 10:36 AM
Lea_WMDE moved this task from MVP things: Ready for pickup to Other on the Wikidata-Termbox board.Jun 3 2019, 10:20 AM
Lea_WMDE closed subtask T221833: Add the "Remember my choice" checkbox to the "You are not logged in" popup on mobile termbox editing, and remember user's choice as Resolved.Jun 12 2019, 2:48 PM
• Hanna_Petruschat_WMDE closed subtask T221831: Add "You are not logged in" overlay popup on termbox editing as Resolved.Jun 17 2019, 7:47 AM
Lea_WMDE closed subtask T221836: Add the "I accept these terms for my future edits" checkbox to License popup on mobile termbox editing, and remember the choice as Resolved.Jul 1 2019, 9:03 AM
• Pablo-WMDE closed subtask T221835: Add CC0 License overlay popup on termbox editing as Resolved.Oct 28 2019, 8:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL