Page MenuHomePhabricator

[Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE
Closed, ResolvedPublic

Description

I couldn't find a consistent workflow to replicate this one, but it happens when you tap towards the end of a paragraph and never seem to be happening second time in a session. Sharing the screen capture here for iOS Safari:

Event Timeline

JTannerWMF subscribed.

We will see how this behaves post production

This is now happening on test.wiki as well, it is very distracting and we should definitely look into it. We fixed a similar bug for source mode last week, but this time it's happening on VE.

Ryasmeen renamed this task from [Pre-deployment bug] Viewport sometimes jumps to the top abruptly on mobile VE to [Regression wmf.23] Viewport sometimes jumps to the top abruptly on mobile VE.Mar 26 2019, 10:19 PM

and calling it a regression since it's not happening on en.wiki.

We will see how this behaves post production

Hey @JTannerWMF, did we decide that because it was not reproducible or something?

I have no idea what could be causing this, and I have not been able to reproduce even once on my device (iPhone SE running iOS 12.1.4). I was testing on the prototype site and on test.wikipedia.org today.

@matmarex: Could you try this one more time following these steps:

  1. Go to this page using iOS Safari: https://test.m.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&mobileaction=toggle_view_mobile
  1. Make sure you have VE as default editor, if not make it default and close the editor and refresh the page again in read mode.
  1. Open mobile VE again
  1. Scroll down to "sub-heading 13:"/"Sub-heading 4:", place your cursor at the end of that line.

Important point: This will not happen the second time in the same session, so once you tried, close the editor, reload the page in read mode and try again.

I really wish that it wouldn't work fine for me.

@Esanders @DLynch Can either of you reproduce and try to debug it?

:(

@matmarex: I see that you had the page loaded from before on the other tab, did you refresh and load it fresh? @ppelberg was able to reproduce it.

I really wish that it wouldn't work fine for me.

I just tried refreshing before opening the editor and got the same result.

ppelberg triaged this task as Medium priority.EditedMar 27 2019, 9:05 PM

Thank you for following down the rabbit hole, @Ryasmeen.

I'm a bit confused to report that I'm no longer able to reproduce the issue. Or more accurately, I haven't been able to reproduce the issue by following the steps below.

@Ryasmeen, I'm convinced what you reported and are experiencing is real. With this in mind, are there different steps or configurations I could explore to tease this out?

Device

iPhone XS
iOS 12.1.4

Steps

  1. Open Safari on an iPhone XS running iOS 12.14
  1. Navigate to: https://test.m.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&mobileaction=toggle_view_mobile
  1. Tap the page-wide edit pencil

VE initiates

  1. Scroll to "sub-heading :13"
  1. Place the cursor immediately to the right of the "3" in "sub-heading:13"

Keyboard emerges

  1. Viewport stays focused on "sub-heading:13"

🔁repeat the steps above, although in step "6." navigate to "sub-heading:4" with the same result

Demonstration

The steps above are represented in this screen capture (iPhone XS | iOS 12.1.4):

Meta

@matmarex: what does "Normal" priority mean to you? Asked differently: when you receive an email that indicates a task's priority level is "Normal" what comes to mind?

Does your thought process resemble one of these?

  1. Let me take a look at this quickly to see if it's something I think should be investigated immediately."
  2. I'll look at this later/tomorrow.
  3. I'm adding this to my #todo list to investigate when I have a free moment.

Context

I ask the above in an effort to make sure I'm understanding priority levels in the same way you are. More specifically, if in marking this task as "Normal" priority it means to you what I think it means.

Also, if our team's understanding of what different priority levels mean is documented somewhere, please let me know. My first stop was to check our team's Editing Team Ceremonies document. cc @JTannerWMF @marcella

*PS: I'm happy to continue this conversation elsewhere if that's cleaner.

Meta

@matmarex: what does "Normal" priority mean to you? Asked differently: when you receive an email that indicates a task's priority level is "Normal" what comes to mind?

In the past we haven't really been using the priority field at all, except for treating "Unbreak now" tasks as very urgent, so I basically stopped looking at it. It seems rather redundant to the workboard workflow on https://phabricator.wikimedia.org/project/board/483/, where tasks are assigned to specific time frames.

I try to look at anything that comes into my inbox from Phabricator within a day or two. I expect to get a message on GChat or IRC for anything that needs more immediate action.

Change 499959 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.MobileArticleTarget: Remove code that may be causing scrolling issues

https://gerrit.wikimedia.org/r/499959

@Ryasmeen I encountered a similar problem when testing the link dialog (for T218635). I am not sure if this is actually the same problem as yours, but I hope it is.

I deployed the patch above to the prototype site (https://visualeditor-prototype.wmflabs.org/wiki/Pride_and_Prejudice). Can you test if it fixes this problem for you?

@Ryasmeen I encountered a similar problem when testing the link dialog (for T218635). I am not sure if this is actually the same problem as yours, but I hope it is.

I deployed the patch above to the prototype site (https://visualeditor-prototype.wmflabs.org/wiki/Pride_and_Prejudice). Can you test if it fixes this problem for you?

Seems fixed to me! Can't reproduce this anymore on our prototype site :)

In the past we haven't really been using the priority field at all, except for treating "Unbreak now" tasks as very urgent, so I basically stopped looking at it. It seems rather redundant to the workboard workflow on https://phabricator.wikimedia.org/project/board/483/, where tasks are assigned to specific time frames.

I try to look at anything that comes into my inbox from Phabricator within a day or two. I expect to get a message on GChat or IRC for anything that needs more immediate action.

Understood, ok. Knowing how notifications are treated is helpful in the context of making sure I'm communicating in the most effective way. So, thank you for explaining, @matmarex.

When can we have the fix for it on Beta cluster?

Change 499959 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.MobileArticleTarget: Remove code causing scrolling issues

https://gerrit.wikimedia.org/r/499959

When can we have the fix for it on Beta cluster?

It's live on Beta now.

When can we have the fix for it on Beta cluster?

It's live on Beta now.

Seems fixed now. Thanks @matmarex! :)