Page MenuHomePhabricator
Create Task
Maniphest T219221

SDC file page rendering is broken for logged-out users on beta cluster
Closed, ResolvedPublic
Actions

Description

Possible causes:

git log --topo-order --no-merges --oneline dcf8976a7b0f25ea326829dd4a0944d7bbe88e13..
e1b15cc (HEAD -> master, origin/master, origin/HEAD) Remove use of removed messages
e0f0b28 Remove blank translations
38d8f65 Localisation updates from https://translatewiki.net.
dde352c Adjust display to cater for diff and historical pages
0dbc0ac EntityLookupElement: Separate alias from label with a word separator
cdf6d65 Deal with cached pages with newer placeholder tags missing
628ec6f Search prototype
1bc65b3 Migrate dependencies to WikibaseCirrusSearch
5e7bda6 Localisation updates from https://translatewiki.net.
722307e Let EntityLookupElement use configured uri by default
63c8e1b Remove $wgMediaInfoShowQualifiers
bedf519 Refactor CaptionsPanel publish button refresh implementation
3f72672 Make sure there's enough space for depicts dropdown
fe8db41 MediaInfoView: revision support for getContent()

Details

SubjectRepoBranchLines +/-
More robust way of extracting nodes from DOMmediawiki/extensions/WikibaseMediaInfomaster+22 -24
Correct extraction of content for tabsmediawiki/extensions/WikibaseMediaInfomaster+10 -12
Output some data to help debug T219221mediawiki/extensions/WikibaseMediaInfomaster+4 -0
Output some data to help debug T219221mediawiki/extensions/WikibaseMediaInfomaster+11 -1
Customize query in gerrit

Related Objects

Mentioned In
rEWBI631b7d0cce9e: Correct extraction of content for tabs
rEWBIfe4337005fe9: Correct extraction of content for tabs
rEWBI83ec2883d6c5: Correct extraction of content for tabs
rEWBI3ede0f8b2581: Correct extraction of content for tabs
rEWBI0cac17af2fc3: Correct extraction of content for tabs
rEWBIaaad807f8095: More robust way of extracting nodes from DOM
rEWBI42a7b4f284eb: Revert "Output some data to help debug T219221"
rEWBI9aeaa40135a3: Output some data to help debug T219221
rEWBI5246c67c09c5: Revert "Output some data to help debug T219221"
rEWBI0efebb936662: Output some data to help debug T219221
rEWBI875ea5dd9b25: Output some data to help debug T219221
rEWBI9be0dc139c30: Output some data to help debug T219221
Mentioned Here
rEWBIbedf519cc1ba: Refactor CaptionsPanel publish button refresh implementation
rEWBIfe8db41f5254: MediaInfoView: revision support for getContent()
rEWBIdcf8976a7b0f: Localisation updates from https://translatewiki.net.
rEWBI3f7267281c68: Make sure there's enough space for depicts dropdown
rEWBI722307ebbb92: Let EntityLookupElement use configured uri by default
rEWBI5e7bda68778a: Localisation updates from https://translatewiki.net.
rEWBI1bc65b33c0ad: Migrate dependencies to WikibaseCirrusSearch
rEWBI628ec6fb63ab: Search prototype
rEWBI0dbc0acb6cd5: EntityLookupElement: Separate alias from label with a word separator
rEWBIcdf6d65dea96: Deal with cached pages with newer placeholder tags missing
rEWBIdde352ca0328: Adjust display to cater for diff and historical pages
rEWBI38d8f657cd0e: Localisation updates from https://translatewiki.net.
rEWBIe0f0b28d9137: Remove blank translations

Event Timeline

Jdforrester-WMF created this task.Mar 25 2019, 7:45 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 25 2019, 7:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF added a comment.Mar 25 2019, 7:47 PM

Possible train-blocker if this breaks non-statement display too.

gerritbot added a comment.Mar 25 2019, 9:50 PM

Change 498994 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] [BETA] SDC: Temporarily disable Depicts on Beta Commons for testing T219221

https://gerrit.wikimedia.org/r/498994

gerritbot added a project: Patch-For-Review.Mar 25 2019, 9:50 PM

Change 498994 merged by jenkins-bot:
[operations/mediawiki-config@master] [BETA] SDC: Temporarily disable Depicts on Beta Commons for testing T219221

https://gerrit.wikimedia.org/r/498994

Jdforrester-WMF added a comment.Mar 25 2019, 10:33 PM

Confirmed that this isn't a train blocker; it'll break on TestCommons but RealCommons will be fine, as this is a statements-only breakage.

Jdforrester-WMF renamed this task from SDC file page rendering is broken for logged-out users on beta cluster (possible train blocker) to SDC file page rendering is broken for logged-out users on beta cluster.Mar 25 2019, 10:33 PM
Jdforrester-WMF removed a project: Patch-For-Review.
Cparle claimed this task.Mar 26 2019, 10:07 AM
gerritbot added a comment.Mar 26 2019, 12:36 PM

Change 499180 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Output some data to help debug T219221

https://gerrit.wikimedia.org/r/499180

gerritbot added a project: Patch-For-Review.Mar 26 2019, 12:36 PM
matthiasmullie mentioned this in rEWBI9be0dc139c30: Output some data to help debug T219221.Mar 26 2019, 12:37 PM
matthiasmullie mentioned this in rEWBI875ea5dd9b25: Output some data to help debug T219221.Mar 26 2019, 12:55 PM
matthiasmullie mentioned this in rEWBI0efebb936662: Output some data to help debug T219221.Mar 26 2019, 1:02 PM
gerritbot added a comment.Mar 26 2019, 1:07 PM

Change 499180 merged by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@master] Output some data to help debug T219221

https://gerrit.wikimedia.org/r/499180

matthiasmullie mentioned this in rEWBI5246c67c09c5: Revert "Output some data to help debug T219221".Mar 26 2019, 1:33 PM
gerritbot added a comment.Mar 26 2019, 1:35 PM

Change 499192 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Output some data to help debug T219221

https://gerrit.wikimedia.org/r/499192

gerritbot added a comment.Mar 26 2019, 1:37 PM

Change 499192 merged by Matthias Mullie:
[mediawiki/extensions/WikibaseMediaInfo@master] Output some data to help debug T219221

https://gerrit.wikimedia.org/r/499192

matthiasmullie mentioned this in rEWBI9aeaa40135a3: Output some data to help debug T219221.Mar 26 2019, 1:37 PM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 26 2019, 2:00 PM
matthiasmullie mentioned this in rEWBI42a7b4f284eb: Revert "Output some data to help debug T219221".Mar 26 2019, 2:03 PM
gerritbot added a comment.Mar 26 2019, 2:50 PM

Change 499213 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] More robust way of extracting nodes from DOM

https://gerrit.wikimedia.org/r/499213

matthiasmullie mentioned this in rEWBIaaad807f8095: More robust way of extracting nodes from DOM.Mar 26 2019, 2:59 PM
gerritbot added a comment.Mar 26 2019, 3:00 PM

Change 499217 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Correct extraction of content for tabs

https://gerrit.wikimedia.org/r/499217

matthiasmullie mentioned this in rEWBI0cac17af2fc3: Correct extraction of content for tabs.Mar 26 2019, 3:06 PM
Jdforrester-WMF mentioned this in rEWBI3ede0f8b2581: Correct extraction of content for tabs.Mar 26 2019, 3:32 PM
matthiasmullie mentioned this in rEWBI83ec2883d6c5: Correct extraction of content for tabs.Mar 26 2019, 3:52 PM
matthiasmullie mentioned this in rEWBIfe4337005fe9: Correct extraction of content for tabs.
matthiasmullie added a project: Structured-Data-Team-Current-Work.Mar 26 2019, 3:59 PM
matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Mar 26 2019, 4:21 PM
• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.Mar 26 2019, 6:16 PM
gerritbot added a comment.Mar 26 2019, 6:21 PM

Change 499217 merged by Jforrester:
[mediawiki/extensions/WikibaseMediaInfo@master] Correct extraction of content for tabs

https://gerrit.wikimedia.org/r/499217

gerritbot added a comment.Mar 26 2019, 6:21 PM

Change 499213 abandoned by Jforrester:
More robust way of extracting nodes from DOM

https://gerrit.wikimedia.org/r/499213

Jdforrester-WMF mentioned this in rEWBI631b7d0cce9e: Correct extraction of content for tabs.Mar 26 2019, 6:27 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.24; 2019-04-02); removed MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 26 2019, 7:01 PM
Jdforrester-WMF closed this task as Resolved.Mar 26 2019, 7:52 PM
Jdforrester-WMF moved this task from Code Review to Verify on Production on the Structured-Data-Team-Current-Work board.
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review.

This is confirmed fixed in Beta Cluster.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL