Page MenuHomePhabricator

Top-to-bottom order of primary/prominent depicts values should change on publish
Closed, ResolvedPublicFeature

Description

User story: N/A

We have this:

When users make a depicts statement primary (soon to be "prominent"), when they hit the Publish button, the order of the statements doesn't change:

make-prominent-primary.PNG (205×262 px, 6 KB)

The order does change on refresh/revisiting the page though.

We want this:

When users change the primary/prominent value for a statement, the order of the values should change as soon as the Publish button is clicked (primary/prominent depict values

make-prominent-primary2.PNG (192×258 px, 5 KB)

Screenshots (if possible):
see above

Acceptance Criteria:

  • After making primary/prominent changes, the order of the statements should change as soon as the Publish button is clicked, with values marked as primary/prominent listed first

Event Timeline

Ramsey-WMF changed the subtype of this task from "Bug Report" to "Feature Request".

@Ha78na , Mark suggested you might want to take a stab at this one :)

Change 500512 had a related patch set uploaded (by Ha78na; owner: Ha78na):
[mediawiki/extensions/WikibaseMediaInfo@master] Order of depicts statements sorted by prominence on publish

https://gerrit.wikimedia.org/r/500512

Change 500512 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Order of depicts statements sorted by prominence on publish

https://gerrit.wikimedia.org/r/500512

Ha78na updated the task description. (Show Details)

Tested on production on 4/23 and works to spec.