Page MenuHomePhabricator
Create Task
Maniphest T219296

Update TermSqlStore to comply with EntityTermStoreWriter interface
Closed, ResolvedPublic
Actions

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseLexememaster+6 -6Change LexemeHandler to use EntityTermStoreWriter
mediawiki/extensions/WikibaseMediaInfomaster+6 -6Change MediaInfoHandler to use EntityTermStoreWriter
mediawiki/extensions/WikibaseLexememaster+5 -5Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler
mediawiki/extensions/WikibaseMediaInfomaster+5 -5Temporarily bind to TermSqlIndex instead of TermIndex in MediaInfoHandler
mediawiki/extensions/Wikibasemaster+88 -106Remove the write parts from TermSql interface and use EntityTermStoreWriter instead
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alaa_wmde created this task.Mar 26 2019, 4:27 PM
• alaa_wmde mentioned this in T219145: Migration Plan 1.Mar 27 2019, 9:22 AM
• alaa_wmde moved this task from Backlog to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.Mar 27 2019, 9:25 AM
Ladsgroup claimed this task.Apr 2 2019, 12:22 PM
Ladsgroup moved this task from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.
Ladsgroup added a subscriber: Ladsgroup.

The current maintenance script needs to be polymorphic, nothing else is needed

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptApr 2 2019, 12:22 PM
gerritbot added a comment.Apr 2 2019, 1:25 PM

Change 500734 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Remove the write parts from TemSql interface and use EntityTermStoreWriter instead

https://gerrit.wikimedia.org/r/500734

gerritbot added a project: Patch-For-Review.Apr 2 2019, 1:25 PM
Ladsgroup moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.Apr 2 2019, 1:26 PM

This is the first bit needed ^

gerritbot added a comment.Apr 2 2019, 2:11 PM

Change 500746 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Change LexemeHandler to use EntityTermStoreWriter

https://gerrit.wikimedia.org/r/500746

Ladsgroup mentioned this in rEWLE4a37554d8675: Change LexemeHandler to use EntityTermStoreWriter.Apr 2 2019, 2:14 PM
gerritbot added a comment.Apr 2 2019, 2:18 PM

Change 500749 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseMediaInfo@master] Cahnge MediaInfoHandler to use EntityTermStoreWriter

https://gerrit.wikimedia.org/r/500749

Ladsgroup mentioned this in rEWBI509b08de80f2: Change MediaInfoHandler to use EntityTermStoreWriter.Apr 2 2019, 2:23 PM
Ladsgroup mentioned this in rEWBI204fc7e7525b: Cahnge MediaInfoHandler to use EntityTermStoreWriter.
Ladsgroup mentioned this in rEWLE74e5e4d4061a: Change LexemeHandler to use EntityTermStoreWriter.Apr 2 2019, 2:39 PM
• alaa_wmde added a comment.Apr 2 2019, 3:06 PM

@Ladsgroup did you mean to attach those changes to this task? this task is about maintenance script that writes to the new schema, not about adjusting the old one to comply to the interface. Those changes can be included as part of this task for sure, but then it is still in progress right?

Ladsgroup added a comment.Apr 2 2019, 3:38 PM
In T219296#5077737, @alaa_wmde wrote:

@Ladsgroup did you mean to attach those changes to this task? this task is about maintenance script that writes to the new schema, not about adjusting the old one to comply to the interface.

I think it was needed, at first I wanted to just fix TermSqlBuilder but at the end I ended up fixing everything.

Those changes can be included as part of this task for sure, but then it is still in progress right?

Yeah but at the same time there are things to review, so :/

• alaa_wmde added a comment.Apr 2 2019, 4:09 PM

well the main part of the task isn't there yet (not even in progress and can't be done before we have PropertyTermStoreWriter). I'll break them down into subtasks (no need to change Bug in current changes, I'll convert this one to the equivalent subtask)

• alaa_wmde renamed this task from Create maintenance script for migrating property terms to new schema to Update TermSqlStore to comply with EntityTermStoreWriter interface.Apr 2 2019, 4:21 PM
• alaa_wmde edited parent tasks, added: T219894: Create maintenance script for migrating property terms to new schema; removed: T219121: [Checkpoint 2] Refactor Write & Migration code for Properties.
gerritbot added a comment.Apr 9 2019, 5:40 PM

Change 502555 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler

https://gerrit.wikimedia.org/r/502555

Ladsgroup mentioned this in rEWLEa1235db426de: Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler.Apr 9 2019, 5:44 PM
Ladsgroup mentioned this in rEWLE7be2e02ab024: Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler.Apr 9 2019, 6:43 PM
Ladsgroup mentioned this in rEWLE8415b0b82b63: Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler.Apr 9 2019, 7:40 PM
gerritbot added a comment.Apr 10 2019, 8:07 AM

Change 502756 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler

https://gerrit.wikimedia.org/r/502756

Ladsgroup mentioned this in rEWBIe4958cb6c208: Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler.Apr 10 2019, 8:11 AM
Jdforrester-WMF mentioned this in rEWBI695c3819ab44: Temporarily bind to TermSqlIndex instead of TermIndex in MediaInfoHandler.Apr 10 2019, 5:30 PM
gerritbot added a comment.Apr 11 2019, 9:02 AM

Change 500734 abandoned by Jeroen De Dauw:
Remove the write parts from TermSql interface and use EntityTermStoreWriter instead

Reason:
New version https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /502952

https://gerrit.wikimedia.org/r/500734

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 12 2019, 10:00 AM
JeroenDeDauw moved this task from In Review to Done on the Wikidata wb_terms Trailblazing board.Apr 12 2019, 11:07 AM
JeroenDeDauw closed this task as Resolved.Apr 12 2019, 11:19 AM
gerritbot added a comment.Apr 17 2019, 7:41 PM

Change 502756 abandoned by Ladsgroup:
Temporarily bind to TermSqlIndex instead of TermIndex in MediaInfoHandler

Reason:
Actually not needed anymore

https://gerrit.wikimedia.org/r/502756

gerritbot added a comment.May 17 2019, 8:10 AM

Change 502555 abandoned by Ladsgroup:
Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler

Reason:
not needed anymore

https://gerrit.wikimedia.org/r/502555

gerritbot added a comment.Aug 26 2019, 12:42 PM

Change 500749 abandoned by Ladsgroup:
Change MediaInfoHandler to use EntityTermStoreWriter

Reason:
Not needed anymore

https://gerrit.wikimedia.org/r/500749

gerritbot added a comment.Aug 26 2019, 12:42 PM

Change 500746 abandoned by Ladsgroup:
Change LexemeHandler to use EntityTermStoreWriter

Reason:
Not needed anymore

https://gerrit.wikimedia.org/r/500746

Maintenance_bot removed a project: Patch-For-Review.Aug 26 2019, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL