Page MenuHomePhabricator

Update TermSqlStore to comply with EntityTermStoreWriter interface
Closed, ResolvedPublic

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterChange LexemeHandler to use EntityTermStoreWriter
mediawiki/extensions/WikibaseMediaInfo : masterChange MediaInfoHandler to use EntityTermStoreWriter
mediawiki/extensions/WikibaseLexeme : masterTemporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler
mediawiki/extensions/WikibaseMediaInfo : masterTemporarily bind to TermSqlIndex instead of TermIndex in MediaInfoHandler
mediawiki/extensions/Wikibase : masterRemove the write parts from TermSql interface and use EntityTermStoreWriter instead

Event Timeline

Ladsgroup added a subscriber: Ladsgroup.

The current maintenance script needs to be polymorphic, nothing else is needed

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptApr 2 2019, 12:22 PM

Change 500734 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Remove the write parts from TemSql interface and use EntityTermStoreWriter instead

https://gerrit.wikimedia.org/r/500734

This is the first bit needed ^

Change 500746 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Change LexemeHandler to use EntityTermStoreWriter

https://gerrit.wikimedia.org/r/500746

Change 500749 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseMediaInfo@master] Cahnge MediaInfoHandler to use EntityTermStoreWriter

https://gerrit.wikimedia.org/r/500749

@Ladsgroup did you mean to attach those changes to this task? this task is about maintenance script that writes to the new schema, not about adjusting the old one to comply to the interface. Those changes can be included as part of this task for sure, but then it is still in progress right?

@Ladsgroup did you mean to attach those changes to this task? this task is about maintenance script that writes to the new schema, not about adjusting the old one to comply to the interface.

I think it was needed, at first I wanted to just fix TermSqlBuilder but at the end I ended up fixing everything.

Those changes can be included as part of this task for sure, but then it is still in progress right?

Yeah but at the same time there are things to review, so :/

well the main part of the task isn't there yet (not even in progress and can't be done before we have PropertyTermStoreWriter). I'll break them down into subtasks (no need to change Bug in current changes, I'll convert this one to the equivalent subtask)

alaa_wmde renamed this task from Create maintenance script for migrating property terms to new schema to Update TermSqlStore to comply with EntityTermStoreWriter interface.Apr 2 2019, 4:21 PM

Change 502555 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler

https://gerrit.wikimedia.org/r/502555

Change 502756 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler

https://gerrit.wikimedia.org/r/502756

Change 500734 abandoned by Jeroen De Dauw:
Remove the write parts from TermSql interface and use EntityTermStoreWriter instead

Reason:
New version https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /502952

https://gerrit.wikimedia.org/r/500734

JeroenDeDauw closed this task as Resolved.Apr 12 2019, 11:19 AM

Change 502756 abandoned by Ladsgroup:
Temporarily bind to TermSqlIndex instead of TermIndex in MediaInfoHandler

Reason:
Actually not needed anymore

https://gerrit.wikimedia.org/r/502756

Change 502555 abandoned by Ladsgroup:
Temporarily bind to TermSqlIndex instead of TermIndex in LexemeHandler

Reason:
not needed anymore

https://gerrit.wikimedia.org/r/502555

Change 500749 abandoned by Ladsgroup:
Change MediaInfoHandler to use EntityTermStoreWriter

Reason:
Not needed anymore

https://gerrit.wikimedia.org/r/500749

Change 500746 abandoned by Ladsgroup:
Change LexemeHandler to use EntityTermStoreWriter

Reason:
Not needed anymore

https://gerrit.wikimedia.org/r/500746