Page MenuHomePhabricator

Lexeme form grammatical feature editing: backspace on pill reveals '[object Object]'
Closed, ResolvedPublic

Description

Environment: production (example)

GIVEN I am on a lexeme page
AND I have edit permission
WHEN I click edit on a form of the lexeme
AND it has grammatical features (pills) already
AND I type backspace to start editing a preexisting grammatical feature
THEN I see "[object Object]" instead of the Q-id / the label of the item (for product to specify)

Likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/491943/1/resources/lib/ooui/oojs-ui-widgets.js#b4390 for T216075

Discovered while tinkering with T219134

Details

Related Gerrit Patches:
mediawiki/extensions/WikibaseLexeme : masterPopulate with entity's label on backspace.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2019, 7:41 PM
Pablo-WMDE updated the task description. (Show Details)Mar 26 2019, 7:55 PM

Change 501191 had a related patch set uploaded (by Greta WMDE; owner: Greta Doçi):
[mediawiki/extensions/WikibaseLexeme@master] Populate with entity's label on backspace.

https://gerrit.wikimedia.org/r/501191

Change 501191 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Populate with entity's label on backspace.

https://gerrit.wikimedia.org/r/501191

The Gerrit change was merged, and the necessary follow-up mentioned in its comments seems to be covered by the separate task T220093, so I think this can leave the review column.