Page MenuHomePhabricator
Create Task
Maniphest T219331

UploadWizard: EXIF DateTime takes precedence over DateTimeOriginal
Closed, ResolvedPublicBUG REPORT
Actions

Description

When UploadWizard prefills dates for uploads, EXIF DateTime takes precedence over DateTimeOriginal. It should be the other way around.

Original bug report: https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#Standard_value_for_Date_work_was_created_or_first_published

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UploadWizard/+/496459/2/resources/mw.UploadWizardDetails.js#479

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UploadWizardmaster+2 -2Fix loop break using Array.some
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Mar 26 2019, 9:45 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptMar 26 2019, 9:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Mar 27 2019, 11:11 AM

Change 499445 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/UploadWizard@master] Fix loop break using Array.some

https://gerrit.wikimedia.org/r/499445

gerritbot added a project: Patch-For-Review.Mar 27 2019, 11:11 AM
matthiasmullie merged a task: T219357: UploadWizard populates the date field with the date and time when the file was modified instead of the date and time the photograph was taken on..Mar 27 2019, 2:06 PM
matthiasmullie added subscribers: JeanFred, Fae, matthiasmullie.
gerritbot added a comment.Mar 27 2019, 2:50 PM

Change 499445 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Fix loop break using Array.some

https://gerrit.wikimedia.org/r/499445

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 3:01 PM
N509FZ added a subscriber: N509FZ.Mar 28 2019, 4:14 PM

Screenshot of the date field problem as of 16:10, 28 March 2019 (UTC): The original photo taken at 17:07:54 (UTC+8), and the retouched photo is modified at 23:09:05 (UTC+8).

uwproblem.png (3×1 px, 546 KB)

Jdforrester-WMF assigned this task to Esanders.Mar 28 2019, 5:52 PM
Jdforrester-WMF removed a project: Patch-For-Review.
In T219331#5066369, @N509FZ wrote:

Screenshot of the date field problem as of 16:10, 28 March 2019 (UTC): The original photo taken at 17:07:54 (UTC+8), and the retouched photo is modified at 23:09:05 (UTC+8).

Thanks for confirming. This is now fixed, and the fix will roll out to Commons next week on 2019-04-03.

Jdforrester-WMF closed this task as Resolved.Mar 28 2019, 5:52 PM
Jdforrester-WMF triaged this task as Medium priority.
matmarex renamed this task from UploadWizard: EXIF DateTime takes prececence over DateTimeOriginal to UploadWizard: EXIF DateTime takes precedence over DateTimeOriginal.Mar 28 2019, 11:47 PM
matmarex merged a task: T219577: Upload wizard bug in dates.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: Cybularny.
Aklapper added a comment.Apr 7 2019, 8:37 AM

T220278 implies that this is not fixed yet.

Jdforrester-WMF added a comment.Apr 8 2019, 6:20 PM
In T219331#5091066, @Aklapper wrote:

T220278 implies that this is not fixed yet.

The train still hasn't rolled out. :-(

Jdforrester-WMF merged a task: T220278: Upload Wizard picks wrong date from last edit instead of the creation date in metadata.Apr 8 2019, 6:20 PM
Jdforrester-WMF added a subscriber: ChristianFerrer.
ChristianFerrer added a comment.Apr 10 2019, 11:16 AM

As far I can see, it seems to be fixed, it works well with my last upload https://commons.wikimedia.org/wiki/File:Harbour_of_S%C3%A8te_and_trawler_BW.jpg , thanks you

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL