WikiPEG has a test suite written in JavaScript with Jasmine, but it is not possible to run it against the PHP generator. Without a test suite, WikiPEG may cause Parsoid to fail in interesting and hard-to-debug ways when the grammar is changed. Ideally, WikiPEG should be of reasonable quality before @tstarling moves on to other things. The idea is to have a shared test file in a DDL similar to parserTests.txt, and a test runner for this file in both JS and PHP.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | tstarling | T219337 Port Parsoid tokenizer to PHP | |||
| Resolved | tstarling | T219339 PHP generator backend for WikiPEG | |||
| Resolved | tstarling | T219341 Cross-language test suite for WikiPEG |
Event Timeline
Comment Actions
Change 501143 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[wikipeg@master] Cross-language testing (PHP side only)
Comment Actions
Change 501144 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[wikipeg@master] Classes for Location, LocationRange and Expectation
Comment Actions
Change 501145 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[wikipeg@master] Remove behavior tests now duplicated to tests.txt
Comment Actions
Change 502044 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[wikipeg@master] Fix PHP assertion counts to match JS
Comment Actions
Change 502045 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[wikipeg@master] JavaScript runner for the cross-language tests
Comment Actions
Change 501143 merged by jenkins-bot:
[wikipeg@master] Cross-language testing (PHP side only)
Comment Actions
Change 501144 merged by jenkins-bot:
[wikipeg@master] Classes for Location, LocationRange and Expectation
Comment Actions
Change 502044 merged by jenkins-bot:
[wikipeg@master] Fix PHP assertion counts to match JS
Comment Actions
Change 502045 merged by jenkins-bot:
[wikipeg@master] JavaScript runner for the cross-language tests
Comment Actions
Change 501145 merged by jenkins-bot:
[wikipeg@master] Remove behavior tests now duplicated to tests.txt