Page MenuHomePhabricator

RecentChanges should be fully skinnable - use pseudo elements for separating elements
Closed, ResolvedPublic

Description

In T205581 many of the special pages overridden by mobile were rewritten to make use of pseudo elements to provide the styling needed to differentiate elements in the UI.

RecentChanges can make use of these improvements, to make it possible to include RecentChanges in the mobile UI (and style consistently)

Remaining work:

With group changes enabled:

  1. Disable the rollback wrapped links (T219948)
  2. Using the technique in #1, migrate .changedby to pseudo elements
  3. Expand a group - the cur and prev links using .mw-changeslist-diff-cur are not wrapped

Event Timeline

Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 27 2019, 12:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 499364 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] RecentChanges updated to use pseudo elements for presentation

https://gerrit.wikimedia.org/r/499364

Change 499360 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Log entries can be rendered with parentheses in HTML

https://gerrit.wikimedia.org/r/499360

Jdlrobson moved this task from Focus to Next up on the User-Jdlrobson board.Mar 27 2019, 10:54 PM

Change 499364 merged by jenkins-bot:
[mediawiki/core@master] RecentChanges updated to use pseudo elements for presentation

https://gerrit.wikimedia.org/r/499364

Reedy added a subscriber: Reedy.

Change 499364 merged by jenkins-bot:
[mediawiki/core@master] RecentChanges updated to use pseudo elements for presentation
https://gerrit.wikimedia.org/r/499364

Caused T220767

kostajh moved this task from Inbox to External on the Growth-Team board.Jul 18 2019, 1:51 AM
kostajh added a subscriber: kostajh.

@Jdlrobson looks like you're on it for this task; but please let us know if you need review or assistance from Growth-Team (with the caveat that our Q1 backlog is pretty full)

Jdlrobson updated the task description. (Show Details)Jul 18 2019, 9:33 PM

Change 499360 merged by jenkins-bot:
[mediawiki/core@master] Log entries can be rendered with parentheses in HTML

https://gerrit.wikimedia.org/r/499360

Jdlrobson closed this task as Resolved.Mon, Sep 23, 6:39 PM
Jdlrobson claimed this task.

Am closing this bug as most of the issues are solved. The remaining issues are documented in bugs:
T222903, T194453, T233649
Thanks all with the help here in making mediawiki a little more responsive.