Page MenuHomePhabricator
Create Task
Maniphest T219348

RecentChanges should be fully skinnable - use pseudo elements for separating elements
Closed, ResolvedPublic
Actions

Description

In T205581 many of the special pages overridden by mobile were rewritten to make use of pseudo elements to provide the styling needed to differentiate elements in the UI.

RecentChanges can make use of these improvements, to make it possible to include RecentChanges in the mobile UI (and style consistently)

Remaining work:

With group changes enabled:

  1. Disable the rollback wrapped links (T219948)
  2. Using the technique in #1, migrate .changedby to pseudo elements
  3. Expand a group - the cur and prev links using .mw-changeslist-diff-cur are not wrapped

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Log entries can be rendered with parentheses in HTMLmediawiki/coremaster+14 -6
RecentChanges updated to use pseudo elements for presentationmediawiki/coremaster+81 -46
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Mar 27 2019, 12:34 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 27 2019, 12:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Mar 27 2019, 12:35 AM

Change 499364 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] RecentChanges updated to use pseudo elements for presentation

https://gerrit.wikimedia.org/r/499364

gerritbot added a project: Patch-For-Review.Mar 27 2019, 12:35 AM
Jdlrobson mentioned this in T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.Mar 27 2019, 12:36 AM
gerritbot added a comment.Mar 27 2019, 12:37 AM

Change 499360 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Log entries can be rendered with parentheses in HTML

https://gerrit.wikimedia.org/r/499360

Jdlrobson moved this task from Doing to Thinking about on the User-Jdlrobson board.Mar 27 2019, 10:54 PM
gerritbot added a comment.Apr 2 2019, 11:13 PM

Change 499364 merged by jenkins-bot:
[mediawiki/core@master] RecentChanges updated to use pseudo elements for presentation

https://gerrit.wikimedia.org/r/499364

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 3 2019, 12:01 AM
Reedy removed a project: Patch-For-Review.Apr 19 2019, 2:02 PM
Reedy subscribed.
In T219348#5080065, @gerritbot wrote:

Change 499364 merged by jenkins-bot:
[mediawiki/core@master] RecentChanges updated to use pseudo elements for presentation

https://gerrit.wikimedia.org/r/499364

Caused T220767

Jdlrobson added a subtask: T194453: Spaces instead of css margin/padding in new Related changes.Jul 3 2019, 5:39 PM
Jdlrobson added a subtask: T222903: Some dot-separators in recent changes and watchlist are missing surrounding whitespace.
kostajh moved this task from Inbox to External on the Growth-Team board.Jul 18 2019, 1:51 AM
kostajh subscribed.

@Jdlrobson looks like you're on it for this task; but please let us know if you need review or assistance from Growth-Team (with the caveat that our Q1 backlog is pretty full)

Jdlrobson updated the task description. (Show Details)Jul 18 2019, 9:33 PM
Etonkovidova closed subtask T219948: Rollback links should not contain [ and ] characters as Resolved.Jul 22 2019, 8:32 PM
kostajh closed subtask T230564: Tags should not have to be comma separated on Contributions, RecentChanges and History as Resolved.Aug 16 2019, 2:46 PM
Volker_E mentioned this in T232085: RTL Wikis problem with tags in RC, history, contribs etc. in Chrome 76 and Chrome 77.Sep 5 2019, 5:55 PM
gerritbot added a comment.Sep 20 2019, 12:22 AM

Change 499360 merged by jenkins-bot:
[mediawiki/core@master] Log entries can be rendered with parentheses in HTML

https://gerrit.wikimedia.org/r/499360

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.24; 2019-09-24).Sep 20 2019, 1:00 AM
Jdlrobson closed this task as Resolved.Sep 23 2019, 6:39 PM
Jdlrobson claimed this task.

Am closing this bug as most of the issues are solved. The remaining issues are documented in bugs:
T222903, T194453, T233649
Thanks all with the help here in making mediawiki a little more responsive.

Jdlrobson added a subtask: T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface.Nov 8 2019, 5:38 PM
ovasileva closed subtask T233649: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface as Resolved.Dec 13 2019, 9:43 AM
matmarex closed subtask T222903: Some dot-separators in recent changes and watchlist are missing surrounding whitespace as Resolved.Feb 5 2020, 4:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits