Page MenuHomePhabricator

Homepage: modify Schema:HelpPanel to accept events from Special:Homepage mentorship and help modules
Closed, ResolvedPublic

Description

Currently mentorship and help modules log to Schema:HelpPanel using editor_interface: homepage. We could modify the schema to accept homepage_mentorship and homepage_help, drop homepage, and update the code to use these two strings.

Event Timeline

MMiller_WMF renamed this task from Modify Schema:HelpPanel to accept events from Special:Homepage mentorship and help modules to Homepage: modify Schema:HelpPanel to accept events from Special:Homepage mentorship and help modules.Mar 27 2019, 5:01 PM
MMiller_WMF subscribed.

Should we consider renaming the schema since it's becoming a more generic schema for posting questions to pages? Or split out the question-asking part from the search & links part (in other words: de-normalize the schema)?

I don't think I'm in favor of either of those at this point, since the schema is only used by us and it's used in only a few places, but I thought I'd bring these questions up.

So currently I'm in favor of the proposed change since we would like to be able to separate between Help module and Mentor module actions taken on the homepage.

Should we consider renaming the schema since it's becoming a more generic schema for posting questions to pages? Or split out the question-asking part from the search & links part (in other words: de-normalize the schema)?

Thanks for bringing up these points.

In theory I would favor splitting out the question asking part, as that's how the code has evolved over time – there's now a generic question posting API and a generic question poster JS widget that's then used by three different implementations. That said, it will be more work to revise this (both creating a new schema, and updating the code) so unless it's a big help to your analysis then I'd say we leave it as is.

In theory I would favor splitting out the question asking part, as that's how the code has evolved over time – there's now a generic question posting API and a generic question poster JS widget that's then used by three different implementations. That said, it will be more work to revise this (both creating a new schema, and updating the code) so unless it's a big help to your analysis then I'd say we leave it as is.

I don't see a huge benefit to doing this at this point, as there would be minimal impact to the analysis (some things would get easier, some things would get harder). Let's keep it as it is, and then revisit it if someone brings it up at a future point.

Change 499849 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Distinguish editor interface for homepage modules

https://gerrit.wikimedia.org/r/499849

@SBisson, during the schema review meeting today we discussed that the homepage_pageview_token generated for HomepageVisit would be exported client-side (noted also in T219431); we'd then want to use this same token as the value for helppanel_session_id in the question-asking logging for mentorship and help modules.

@SBisson, during the schema review meeting today we discussed that the homepage_pageview_token generated for HomepageVisit would be exported client-side (noted also in T219431); we'd then want to use this same token as the value for helppanel_session_id in the question-asking logging for mentorship and help modules.

Done. This is now ready for review.

Etonkovidova subscribed.

Checked in betalabs - editor_interface has records for homepage_mentorship and homepage_help.