Page MenuHomePhabricator

Flash of page in talk modal transition
Open, Stalled, NormalPublic

Description

Steps to reproduce

  1. Go to discussions and tap on a discussion

Expected results

  • The transition is fluid

Actual results

  • There's a flash of the page on the layer below the modal

Environments observed

  • Browser version: multiple including Safari mobile for iOS 12
  • OS version: multiple including iOS 12
  • Device model: multiple including iPhone
  • Device language: Spanish

Check any additional observations

See for example https://es.m.wikipedia.org/wiki/Inglaterra#/talk while logged in with AMC enabled

Developer notes

The issue was identified and fixed as part of T217102 which stalled and never got completed. The problem is caused by the fact that TalkSectionOverlay extends Overlay, and thus there is a delay while loading the code. I don't see a shortcut to fixing this other than taking care of T217102 so this is stalled on that.

Compare this (language overlay and talk overlay are both using composition:

mw.loader.using('mobile.talk.overlays').then( function () {
 window.location.hash = '#/talk';
setTimeout(()=> { window.location.hash = '#/languages'; }, 1000 );
} );

with

mw.loader.using('mobile.talk.overlays').then( function () {
 window.location.hash = '#/talk';
setTimeout(()=> { window.location.hash = '#/talk/1'; }, 1000 );
} );

where /talk/1 is associated with an overlay not using composition.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2019, 2:08 PM
dr0ptp4kt renamed this task from [Bug] Example title to Flash of page in modal transition.Mar 27 2019, 2:09 PM
ovasileva triaged this task as Normal priority.Mar 28 2019, 12:36 PM
ovasileva updated the task description. (Show Details)
Jdlrobson renamed this task from Flash of page in modal transition to Flash of page in talk modal transition.Apr 2 2019, 3:55 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson changed the task status from Open to Stalled.Apr 2 2019, 11:06 PM
Jdlrobson updated the task description. (Show Details)