Maniphest T219426

Captions broken
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

attempt to add a caption to existing file
once caption is added 'cancel' and 'publish' buttons do not get hidden
error in console jQuery.Deferred exception: self.languageSelectors[index] is undefined

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Trigger confirm when cancel button is clicked instead of in makeReadOnly()	mediawiki/extensions/WikibaseMediaInfo	master	+27 -38

Customize query in gerrit

Related Objects

Mentioned In: T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes
rEWBIb18a0777d7b8: Trigger confirm when cancel button is clicked instead of in makeReadOnly()
Mentioned Here: T219197: Show "changes you made may not be saved" alert for structured data fields

Event Timeline

Cparle created this task.Mar 27 2019, 5:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2019, 5:25 PM

Change 499553 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Trigger confirm when cancel button is clicked instead of in makeReadOnly()

https://gerrit.wikimedia.org/r/499553

gerritbot added a project: Patch-For-Review.Mar 27 2019, 5:58 PM

Cparle mentioned this in rEWBIb18a0777d7b8: Trigger confirm when cancel button is clicked instead of in makeReadOnly().Mar 27 2019, 5:59 PM

Change 499553 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Trigger confirm when cancel button is clicked instead of in makeReadOnly()

https://gerrit.wikimedia.org/r/499553

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 10:01 PM

Jdforrester-WMF assigned this task to Cparle.Mar 27 2019, 10:14 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF moved this task from To Do to Verify on Production on the Structured-Data-Team-Current-Work board.

For posterity: this bug was regression caused by T219197 which had recently merged. We luckily noticed it on beta before it got any further.

• Ramsey-WMF triaged this task as High priority.Mar 28 2019, 1:22 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

• Ramsey-WMF moved this task from To Do to Verify on Production on the Structured Data Engineering board.

• Ha78na mentioned this in T219500: Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes.Mar 28 2019, 1:37 PM

ok on test-commons