Page MenuHomePhabricator

Make filtering UI handle certain unaccounted-for states
Closed, ResolvedPublic2 Estimated Story Points

Description

Now that T218340 is working, we can see certain use cases that are not being handled correctly. This ticket adjusts the messaging for these. (It also adds one small text change to the Categories filtering panel.)

1) Totals not yet calculated

There is a pre-existing, Grant Metrics state I didn't know about that shows up whenever the user has not yet calculated totals after Saving Settings (whether during initial setup or after a subsequent Settings change is irrelevant). In such cases, the "Update data" button is instead called "Calculate totals," and a green banner at page top shows up with some messaging we don't need. The items below show how to fix this messaging for the Unfiltered, Partial and Valid states. ( Note that in no case should there ever be two green banners.)

Any UNFILTERED STATE

  • Do not show the top green banner.
    • Other than that, it looks fine.

Screen Shot 2019-03-26 at 10.01.06 PM.png (752×1 px, 141 KB)

Any PARTIAL states where the user has NOT YET CALCULATED TOTALS since Saving Settings (including Partial state with Wikidata)

  • Do not show the top green banner.
  • For the subtitle, use "Calculate totals" language instead of the "Update data" language, like so:
    • "You will get metrics for some but not all of the wikis specified for the event. Click Calculate totals to get metrics."
  • Note: In cases where the event is in Partial but the user HAS "Calculated totals" after saving, continue to use the "Update data" messaging defined in T218340, as now.

Screen Shot 2019-03-26 at 9.41.29 PM.png (840×1 px, 183 KB)

VALID states where the user has NOT YET CALCULATED TOTALS since Saving Settings

  • Do not show the top green banner. Show only the one above the filters.
  • For the subtitle, use "calculate totals" language instead of the "update data" language, like so (actually, I've rewritten this whole message, FYI):
    • "Event settings saved successfully. Click Calculate totals to get metrics. "
  • Note: the green banner should be shown only when all filters saved are valid. fixed in T219464.

Screen Shot 2019-03-26 at 10.21.34 PM.png (581×1 px, 105 KB)

2) This event is in the Future

Another message not accounted for in the design is the one pictured below, which appears when the event takes place in the future.

  • Do not show the top green banner.
  • To display the message, use the Partial style (yellow) Error box with the following title/subtitle:
    • This event takes place in the future
    • Statistics can't be generated yet. If you want to change dates, go to Settings. [Where clicking Settings takes the user to the Event Settings page.]

future message image.png (634×1 px, 104 KB)

3) Text change to Categories filtering panel

  • Alex and Sati asked us to add another line to the instruction text for Categories. Because this makes the instruction text a bit long, we will break it up into two lines, with bullets. Prateek has provided code to show styling for the bullets, since we haven't used them in that spot before.
  • Enter categories (with wiki names) to limit metrics to pages in those categories.
  • Categories must be on main namespace pages; hidden categories are allowed. [this is the NEW bit]
  • On Commons only, use this tool to filter files (images, videos, etc.), instead of pages.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mooeypoo set the point value for this task to 2.Mar 27 2019, 10:46 PM

The PR (253) for this has been merged.

Hi @Samwilson
Everything looks good here except the bit about putting the "This Event Is In the Future" language into the yellow, Partial-style Error box. I'm still getting the green banner style and the old message. From the Description, above:

  • To display the message, use the Partial style (yellow) Error box with the following title/subtitle:
    • This event takes place in the future
    • Statistics can't be generated yet. If you want to change dates, go to Settings. [Where clicking Settings takes the user to the Event Settings page.]

(I'm also still seeing the green banner when I save invalid settings, but I'll have Max fix that in T219464. Just mentioning so you guys don't somehow work at cross purposes.)

Oh yes, I had thought that was coming in @MusikAnimal's new-banner-style, but that's different (and I think can wait for the time being).

I've fixed up the future message, and PR257 is ready for review.

jmatazzoni updated the task description. (Show Details)

Tested out the "This event takes place in the future" bar, and it looks great. Resolving this.