Page MenuHomePhabricator

[Bug] PHP Warning: in_array() expects parameter 2 to be an array or collection in extensions/FlaggedRevs/backend/FlaggedRevs.class.php:971
Closed, ResolvedPublic

Description

Logstash reports several warnings passing through NewUserMessage and FlaggedRevs extensions:

#0 /srv/mediawiki/php-1.33.0-wmf.22/extensions/FlaggedRevs/backend/FlaggedRevs.class.php(971): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.33.0-wmf.22/extensions/FlaggedRevs/backend/FlaggableWikiPage.php(406): FlaggedRevs::inReviewNamespace(Title)
#2 /srv/mediawiki/php-1.33.0-wmf.22/extensions/FlaggedRevs/backend/FlaggedRevs.hooks.php(404): FlaggableWikiPage->loadPageData(stdClass)
#3 /srv/mediawiki/php-1.33.0-wmf.22/includes/Hooks.php(174): FlaggedRevsHooks::maybeMakeEditReviewed(WikiPage, Revision, boolean, User, array)
#4 /srv/mediawiki/php-1.33.0-wmf.22/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#5 /srv/mediawiki/php-1.33.0-wmf.22/includes/Storage/PageUpdater.php(1134): Hooks::run(string, array)
#6 /srv/mediawiki/php-1.33.0-wmf.22/includes/Storage/PageUpdater.php(758): MediaWiki\Storage\PageUpdater->doCreate(CommentStoreComment, User, integer)
#7 /srv/mediawiki/php-1.33.0-wmf.22/includes/page/WikiPage.php(1916): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#8 /srv/mediawiki/php-1.33.0-wmf.22/extensions/NewUserMessage/NewUserMessage.class.php(252): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer, boolean, User)
#9 /srv/mediawiki/php-1.33.0-wmf.22/extensions/NewUserMessage/NewUserMessage.class.php(185): NewUserMessage::leaveUserMessage(User, WikiPage, string, string, string, string, User, integer)
#10 /srv/mediawiki/php-1.33.0-wmf.22/extensions/NewUserMessage/NewUserMessage.class.php(202): NewUserMessage::createNewUserMessage(User)
#11 /srv/mediawiki/php-1.33.0-wmf.22/includes/deferred/MWCallableUpdate.php(34): Closure$NewUserMessage::onLocalUserCreated()
#12 /srv/mediawiki/php-1.33.0-wmf.22/includes/deferred/DeferredUpdates.php(273): MWCallableUpdate->doUpdate()
#13 /srv/mediawiki/php-1.33.0-wmf.22/includes/deferred/DeferredUpdates.php(219): DeferredUpdates::runUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#14 /srv/mediawiki/php-1.33.0-wmf.22/includes/deferred/DeferredUpdates.php(139): DeferredUpdates::execute(array, string, integer)
#15 /srv/mediawiki/php-1.33.0-wmf.22/includes/MediaWiki.php(602): DeferredUpdates::doUpdates(string, integer)
#16 /srv/mediawiki/php-1.33.0-wmf.22/includes/api/ApiMain.php(548): MediaWiki::preOutputCommit(DerivativeContext)
#17 /srv/mediawiki/php-1.33.0-wmf.22/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#18 /srv/mediawiki/php-1.33.0-wmf.22/api.php(87): ApiMain->execute()
#19 /srv/mediawiki/w/api.php(3): include(string)
#20 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2019, 7:03 PM
kostajh closed this task as Resolved.Wed, Jul 3, 4:56 PM
kostajh claimed this task.
kostajh added a subscriber: kostajh.

@Niedzielski are you still seeing this? I can't find instances of it in Logstash in the last 30 days. Please re-open if it's still seen.