Page MenuHomePhabricator

Opening VisualEditor in a disabled namespace with 2017 wikitext editor enabled displays raw Parsoid HTML
Closed, ResolvedPublic

Description

Reproduction steps

I've observed this occurs in Firefox 67 and Chrome 73 on macOS, although in a couple of cases it seemed like I had to log out and log in again for it to work.

  1. Enable the "New Wikitext Editor" beta feature
  2. Attempt to manually open the VisualEditor in namespace where it's disabled by adding the query parameter veaction=edit to the URL (for example, navigating to https://en.wikipedia.org/wiki/Wikipedia:Requested_articles?veaction=edit)
  3. Observe that the 2017 wikitext editor has opened, but the text area contains the page's raw Parsoid HTML rather than the wikitext. For example:
    Screen Shot 2019-03-27 at 14.38.49.png (1×1 px, 826 KB)
In T199411, @Schnark wrote:

The actual result depends on your settings:

  1. If you have NWE enabled: You are editing the HTML (not the wikitext) in source mode.
  2. If you never edited before: You are shown a welcoming dialog without any button to close.
  3. If neither of the above: You edit in VE, but with a few bugs. E.g. when reviewing your changes there will be an additional loading bar that doesn't go away.

Event Timeline

Restricted Application added a project: VisualEditor. · View Herald Transcript

Change 502871 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Add sanity check against loading content in wrong mode

https://gerrit.wikimedia.org/r/502871

Change 502872 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Validate 'veaction' parameter against available modes

https://gerrit.wikimedia.org/r/502872

Change 502871 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.ArticleTarget: Add sanity check against loading content in wrong mode

https://gerrit.wikimedia.org/r/502871

Change 502872 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.init.mw.DesktopArticleTarget: Validate 'veaction' parameter against available modes

https://gerrit.wikimedia.org/r/502872

Thanks for finding those tasks! I didn't realize this is such an old issue.

JTannerWMF added a subscriber: ppelberg.

Closing this task for @ppelberg