Page MenuHomePhabricator

Empty quantities input when searching (qualifiers) should parse a proper value into the search string
Closed, ResolvedPublic

Description

Not inputting a value in the qualifiers input should probably be treated as 0.

Acceptance criteria:

Can be tested on https://federated-commons.wmflabs.org/wiki/Main_Page in the top-right search widget.

  • Clicking a capsule in the search menu's "tags" input mode reveals the qualifiers popover
  • Selecting the "quantity" and any (not "is empty") operator reveals the quantity input field
  • Don't input any value
  • Submit the search form, taking you to Special:Search
  • The search term does not include ${value} (instead, nothing or 0 should be parsed in there)

QA Results

ACStatusDetails
1T219491#5188262
2T219491#5188262
3T219491#5188262

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 499730 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Parse '0' into the search string when quantity input is empty

https://gerrit.wikimedia.org/r/499730

Change 499730 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Parse '0' into the search string when quantity input is empty

https://gerrit.wikimedia.org/r/499730

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

Acceptance criteria:

Can be tested on https://federated-commons.wmflabs.org/wiki/Main_Page in the top-right search widget.

✅ AC1: Clicking a capsule in the search menu's "tags" input mode reveals the qualifiers popover

Screen Shot 2019-05-16 at 3.26.40 PM.png (1×1 px, 337 KB)

✅ AC2: Selecting the "quantity" and any (not "is empty") operator reveals the quantity input field

Screen Shot 2019-05-16 at 3.34.08 PM.png (1×1 px, 338 KB)

✅ AC3: Don't input any value
Submit the search form, taking you to Special:Search
The search term does not include ${value} (instead, nothing or 0 should be parsed in there)

Screen Shot 2019-05-16 at 3.39.16 PM.png (1×1 px, 260 KB)

Edtadros updated the task description. (Show Details)
Edtadros added a subscriber: Edtadros.

Can't verify this one until we've worked on the new search gadget. Removing from Current Work board for now.

This seems to be like a problem with translating frontend input into wbstatementquantity queries. We don't have the frontend that's described here anymore, so closing the ticket