Maniphest T219491

Empty quantities input when searching (qualifiers) should parse a proper value into the search string
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matthiasmullie
	Mar 28 2019, 9:26 AM

Description

Not inputting a value in the qualifiers input should probably be treated as 0.

Acceptance criteria:

Can be tested on https://federated-commons.wmflabs.org/wiki/Main_Page in the top-right search widget.

Clicking a capsule in the search menu's "tags" input mode reveals the qualifiers popover
Selecting the "quantity" and any (not "is empty") operator reveals the quantity input field
Don't input any value
Submit the search form, taking you to Special:Search
The search term does not include ${value} (instead, nothing or 0 should be parsed in there)

QA Results

AC	Status	Details
1	✅	T219491#5188262
2	✅	T219491#5188262
3	✅	T219491#5188262

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikibaseMediaInfo	master	+2 -2	Parse '0' into the search string when quantity input is empty

Customize query in gerrit

Related Objects

Mentioned In: rEWBI63aa1fcd7d4a: Parse '0' into the search string when quantity input is empty

Event Timeline

matthiasmullie created this task.Mar 28 2019, 9:26 AM

Restricted Application added a project: Multimedia. · View Herald TranscriptMar 28 2019, 9:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

matthiasmullie moved this task from To Do to Code Review on the Structured-Data-Team-Current-Work board.Mar 28 2019, 9:27 AM

• Ramsey-WMF triaged this task as Medium priority.Mar 28 2019, 2:26 PM

• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.

• Ramsey-WMF added a project: SDC-Statements (Depicts-on-training-wheels).

Change 499730 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Parse '0' into the search string when quantity input is empty

https://gerrit.wikimedia.org/r/499730

gerritbot added a project: Patch-For-Review.Mar 28 2019, 5:16 PM

matthiasmullie mentioned this in rEWBI63aa1fcd7d4a: Parse '0' into the search string when quantity input is empty.Mar 28 2019, 5:19 PM

Change 499730 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Parse '0' into the search string when quantity input is empty

https://gerrit.wikimedia.org/r/499730

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 28 2019, 8:02 PM

Jdforrester-WMF moved this task from Code Review to Needs QA on the Structured-Data-Team-Current-Work board.Mar 28 2019, 9:53 PM

Jdforrester-WMF removed a project: Patch-For-Review.

matthiasmullie updated the task description. (Show Details)Mar 29 2019, 8:14 AM

matthiasmullie reassigned this task from matthiasmullie to Edtadros.Mar 29 2019, 11:40 AM

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome
Device: MBP

Test Artifact(s):

Acceptance criteria:

Can be tested on https://federated-commons.wmflabs.org/wiki/Main_Page in the top-right search widget.

✅ AC1: Clicking a capsule in the search menu's "tags" input mode reveals the qualifiers popover

Screen Shot 2019-05-16 at 3.26.40 PM.png (1×1 px, 337 KB)

✅ AC2: Selecting the "quantity" and any (not "is empty") operator reveals the quantity input field

Screen Shot 2019-05-16 at 3.34.08 PM.png (1×1 px, 338 KB)

✅ AC3: Don't input any value
Submit the search form, taking you to Special:Search
The search term does not include ${value} (instead, nothing or 0 should be parsed in there)

Screen Shot 2019-05-16 at 3.39.16 PM.png (1×1 px, 260 KB)

Edtadros reassigned this task from Edtadros to • Ramsey-WMF.May 16 2019, 10:45 PM

Edtadros updated the task description. (Show Details)

Edtadros added a subscriber: Edtadros.

Can't verify this one until we've worked on the new search gadget. Removing from Current Work board for now.

Aklapper edited projects, added Structured-Data-Backlog; removed Multimedia.Aug 10 2019, 11:55 PM

• Sarahmarie1981 edited projects, added WMDE-Tech-Communication-Source-Code-Berlin; removed Structured-Data-Backlog.Mar 16 2020, 3:38 PM

Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMar 16 2020, 3:38 PM

Aklapper removed a project: WMDE-Tech-Communication-Source-Code-Berlin.Mar 16 2020, 4:02 PM

CBogen moved this task from Triage to Needs Discussion on the Structured-Data-Backlog board.Sep 1 2020, 5:06 PM

This seems to be like a problem with translating frontend input into wbstatementquantity queries. We don't have the frontend that's described here anymore, so closing the ticket

Cparle closed this task as Resolved.Sep 14 2020, 4:48 PM

	F29075051: Screen Shot 2019-05-16 at 3.26.40 PM.png
	May 16 2019, 10:40 PM

	F29075083: Screen Shot 2019-05-16 at 3.34.08 PM.png
	May 16 2019, 10:40 PM

	F29075175: Screen Shot 2019-05-16 at 3.39.16 PM.png
	May 16 2019, 10:40 PM

Empty quantities input when searching (qualifiers) should parse a proper value into the search stringClosed, ResolvedPublicActions