Page MenuHomePhabricator
Create Task
Maniphest T219500

Unit Test: Add tests that ensures cancel/publish buttons are hidden and shown in proper modes
Closed, ResolvedPublic
Actions

Description

In general when we have a bug that can we addressed by unit tests, we should write tests soon after encountering the bug. This prevents similar issues from requiring manual QA to be revealed.

To keep an issue T219426 from occurring again here are tests we should attempt write:

Acceptance Criteria:

  • In captions read mode, cancel/publish buttons are hidden
  • In captions edit mode, cancel button is visible
  • In captions edit mode, publish button is visible
  • In captions edit mode, clicking cancel button with no edits in progress hides cancel/publish buttons
  • In depicts read mode, cancel/publish buttons are hidden
  • In depicts edit mode, cancel button is visible
  • In depicts edit mode, publish button is visible
  • In depicts edit mode, clicking cancel button with no edits in progress hides cancel/publish buttons

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseMediaInfomaster+380 -78Unit tests for CaptionPanel.js
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Ha78na created this task.Mar 28 2019, 1:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2019, 1:37 PM
• Ramsey-WMF triaged this task as Medium priority.Mar 28 2019, 2:31 PM
• Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.
• Ramsey-WMF added a project: Structured Data Engineering.
• Ramsey-WMF added subscribers: egardner, MarkTraceur, matthiasmullie and 2 others.
• Ha78na claimed this task.Apr 11 2019, 1:53 PM
• Ha78na moved this task from To Do to Doing on the Structured-Data-Team-Current-Work board.
• Ha78na updated the task description. (Show Details)Apr 11 2019, 7:27 PM
• Ha78na added a parent task: T220774: Add JS Unit tests to safeguard Filepage UI happy-paths [Epic].Apr 15 2019, 5:35 PM
• Ha78na updated the task description. (Show Details)May 2 2019, 7:49 PM
• Ha78na added a comment.May 2 2019, 7:53 PM

The depicts work was covered in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseMediaInfo/+/504225/ the captions work is not complete.

I wasn't able to get the tests passing and failing properly by stubbing out method calls inside makeEditable in the captions panel tests.

• Ramsey-WMF reassigned this task from • Ha78na to Cparle.May 10 2019, 5:06 PM
• Ramsey-WMF moved this task from To Do to Doing on the Structured Data Engineering board.
Cparle removed Cparle as the assignee of this task.May 31 2019, 8:44 AM
Cparle moved this task from Doing to To Do on the Structured-Data-Team-Current-Work board.
Cparle claimed this task.Jun 17 2019, 10:59 AM
Cparle moved this task from To Do to Doing on the Structured-Data-Team-Current-Work board.Jun 17 2019, 11:05 AM
gerritbot added a comment.Jun 18 2019, 10:13 AM

Change 517614 had a related patch set uploaded (by Cparle; owner: Cparle):
[mediawiki/extensions/WikibaseMediaInfo@master] Work in progress

https://gerrit.wikimedia.org/r/517614

gerritbot added a project: Patch-For-Review.Jun 18 2019, 10:13 AM
gerritbot added a comment.Jul 9 2019, 8:42 AM

Change 517614 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Unit tests for CaptionPanel.js

https://gerrit.wikimedia.org/r/517614

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.13; 2019-07-09).Jul 9 2019, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 9 2019, 9:11 AM
• Ramsey-WMF closed this task as Resolved.Aug 8 2019, 5:51 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL