Page MenuHomePhabricator
Create Task
Maniphest T219508

Table contexts misplaced on first focus
Closed, ResolvedPublic
Actions

Description

Regression caused by T219066:

image.png (752×441 px, 71 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Emit 'position' event on surface view after changing doc paddingmediawiki/extensions/VisualEditormaster+5 -3
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 28 2019, 2:34 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptMar 28 2019, 2:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders mentioned this in T219066: Cursor pushed off screen when focussing first line in iOS.Mar 28 2019, 2:35 PM

We probably just need to emit a position event when the padding is changed?

gerritbot added a comment.Mar 28 2019, 2:41 PM

Change 499783 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Emit 'position' event on surface view after changing doc padding

https://gerrit.wikimedia.org/r/499783

Esanders claimed this task.Mar 28 2019, 2:41 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
gerritbot edited projects, added Patch-For-Review, VisualEditor; removed VisualEditor (Current work).Mar 28 2019, 2:41 PM
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 28 2019, 2:42 PM
Esanders moved this task from Incoming to QA on the VisualEditor (Current work) board.
matmarex moved this task from QA to Code review on the VisualEditor (Current work) board.Mar 28 2019, 7:31 PM
gerritbot added a comment.Mar 28 2019, 7:40 PM

Change 499783 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Emit 'position' event on surface view after changing doc padding

https://gerrit.wikimedia.org/r/499783

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 28 2019, 8:02 PM
matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Mar 28 2019, 10:01 PM
Ryasmeen added a project: Verified.Apr 2 2019, 7:58 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
ppelberg closed this task as Resolved.May 22 2019, 1:45 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits