Maniphest T219549

Simplify WikibaseRepo "mw.config.values.wbSiteDetails" module and use content versioning
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Krinkle
	Mar 28 2019, 7:44 PM

Description

This is a bit of minor tech debt to simplify the code and use newer ResourceLoader mechanisms.

Follows-up: T127275: Wikibase RL module mw.config.values.wbSiteDetails repeatedly flapping.

I attempted this previously with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/496622/, but this led to a regression (T219452). This task is placeholder for:

Figuring out what went wrong.
Improve the tests.
Do it again :)

Details

	Subject	Repo	Branch	Lines +/-
	Use module 'factory' for dependency injection to SitesModule class	mediawiki/extensions/Wikibase	master	+258 -385
	Use enableModuleContentVersion() for Wikibase\lib\SitesModule (take 2)	mediawiki/extensions/Wikibase	master	+144 -171

Customize query in gerrit

Related Objects

Mentioned Here: T127275: Wikibase RL module mw.config.values.wbSiteDetails repeatedly flapping
T219452: Cannot add a Wikidata sitelink [2019-03-27]

Event Timeline

Krinkle created this task.Mar 28 2019, 7:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 28 2019, 7:44 PM

Krinkle updated the task description. (Show Details)Mar 28 2019, 7:45 PM

With the help of @Addshore I was able to get Wikibase set up locally with the sites table populated from the WMF site matrix.

The issue is with the suggestions that appear when inserting a new site link statement.

Screenshot 2019-03-28 at 19.46.59.png (1×935 px, 111 KB)

With the patch applied, there are no suggestions (but also no errors; not in PHP, JS, nor on the network).

Comparing the module output reveals the issue:

The data structure has the correct size, keys and value structure. But, the values (groups, display names, urls) are all the same, for aawiki.

This explains why (except when typing "aa"), there were no suggestions.

Change 499920 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Wikibase@master] Use enableModuleContentVersion() for Wikibase\lib\SitesModule (take 2)

https://gerrit.wikimedia.org/r/499920

Change 499946 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Wikibase@master] Use module 'factory' to inject dependencies instead of worker class

https://gerrit.wikimedia.org/r/499946

• alaa_wmde moved this task from incoming to in progress on the Wikidata board.Apr 2 2019, 8:51 AM

• alaa_wmde added a project: Wikidata-Campsite.

• alaa_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

• alaa_wmde moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

• alaa_wmde subscribed.

Change 499920 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use enableModuleContentVersion() for Wikibase\lib\SitesModule (take 2)

https://gerrit.wikimedia.org/r/499920

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.25; 2019-04-09).Apr 9 2019, 12:01 PM

noarave moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 9 2019, 12:19 PM

Change 499946 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use module 'factory' for dependency injection to SitesModule class