Page MenuHomePhabricator

Migrate Wikimedia wikis to MediaWiki:Cite-tool-definition.json rather than MediaWiki:Visualeditor-cite-tool-definition.json and drop b/c
Closed, ResolvedPublic

Description

Generated using Wikimedia Global Search on 2025-01-06 17:22

(UPDATE: 2025-01-09)

DONE:

DONE (Deleted) - Destination already exists:

ALREADY DONE LOCALLY:

DONE 09-05-2025

Event Timeline

Jdforrester-WMF triaged this task as Lowest priority.

Is there a related task for this somewhere? Or code? (Like if I did this today it'd all be fine, right?) :)

(And what does drop b/c mean?)

Is there a related task for this somewhere? Or code? (Like if I did this today it'd all be fine, right?) :)

This is the task? Yes, go for it.

(And what does drop b/c mean?)

Drop backwards-compatibility, i.e. stop the inefficiency of reading the <visualeditor-cite-tool-definition.json> message as well on every page load.

Mvolz renamed this task from Migrate Wikimedia wikis to MediaWiki:cite-tool-definition.json rather than MediaWiki:visualeditor-cite-tool-definition.json and drop b/c to Migrate Wikimedia wikis to MediaWiki:Cite-tool-definition.json rather than MediaWiki:Visualeditor-cite-tool-definition.json and drop b/c.EditedJan 15 2023, 12:26 PM
Mvolz updated the task description. (Show Details)

I have moved pages where I had permission. On a few wikis, moves have special restrictions. I didn't have enough edits on https://he.wikipedia.org/ and on https://bg.wikipedia.org/ it was detected as vandalism.

On the other remaining wikis, page moves are an action which requires full administrator privileges. As only having global interface editor right I lack the permissions to move the page.

I could blank in fact the existing page and create the replacement on those wikis; the only issue with that is it doesn't preserve history, but I tested this on test2 wiki (which has similar settings) and it works. I feel like global interface editors should have the permission to move pages but oh well!

Mvolz updated the task description. (Show Details)

On the other remaining wikis, page moves are an action which requires full administrator privileges. As only having global interface editor right I lack the permissions to move the page.

I could blank in fact the existing page and create the replacement on those wikis; the only issue with that is it doesn't preserve history, but I tested this on test2 wiki (which has similar settings) and it works. I feel like global interface editors should have the permission to move pages but oh well!

Yeah, it's a tad silly. :-( (I also don't have the move right, even as a +sysadmin.)

Should we ask the stewards to do this?

I've moved 11 of the remaining 37 pages, but the other 26 will require someone with more rights across all wikis.

Should we ask the stewards to do this?

Yes please.

What's the point of this? I can see on cs.wv it is MediaWiki:Visualeditor-cite-tool-definition.json. I want to propose creating that page on en.wv, so should it also be created as MediaWiki:Cite-tool-definition.json?

What's the point of this? I can see on cs.wv it is MediaWiki:Visualeditor-cite-tool-definition.json. I want to propose creating that page on en.wv, so should it also be created as MediaWiki:Cite-tool-definition.json?

Yes, it should be created as MediaWiki:Cite-tool-definition.json

The message was originally renamed because of naming conventions, as it was moved from the VisualEditor extension to the Cite extension, I think? Done in T138573

Nemoralis subscribed.

I moved the page on az.wikipedia

I've moved 11 of the remaining 37 pages, but the other 26 will require someone with more rights across all wikis.

Should we ask the stewards to do this?

Yes please.

Posted as https://meta.wikimedia.org/wiki/Steward_requests/Miscellaneous#Move_various_MediaWiki:Visualeditor-cite-tool-definition.json_pages_to_MediaWiki:Cite-tool-definition.json

Xaosflux subscribed.

Pages in scope of the stewards/global sysops have been moved. (editsitejson) is included in the administrator group, for projects with local administrators please follow up with the project.

Thanks!

NOT DONE COLLISION AT DESTINATION PAGE:

In this case, the "old" page (MediaWiki:Visualeditor-cite-tool-definition.json) can be deleted because the code will ignore it if the new one already exists.

This is now done and it is safe to remove the fallback messages (for WMF wikis, at least) (unless someone creates a new one in the interrum)

Change #1143757 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Cite@master] Drop back-compatibility loading of visualeditor-cite-tool-definition.json

https://gerrit.wikimedia.org/r/1143757

Change #1143757 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop back-compatibility loading of visualeditor-cite-tool-definition.json

https://gerrit.wikimedia.org/r/1143757

Mvolz moved this task from Inbox to QA on the Editing-team (Kanban Board) board.
Mvolz added a project: Editing QA.
Esanders claimed this task.
Esanders awarded a token.

Apparently, the relevant page at plwiki was somehow missed. I've just moved it manually, as users reported that options for creating a citation disappeared from VE.

Apparently, the relevant page at plwiki was somehow missed. I've just moved it manually, as users reported that options for creating a citation disappeared from VE.

Thanks for doing that. I can replicate the global search issue by doing https://global-search.toolforge.org/?q=Cite-tool-definition.json&namespaces=8&title=Cite-tool-definition.json which also misses pl.wikipedia for some reason.

For some reason for the mediawiki namespace including the page title in the q parameter causes a search miss - but only for pl wiki. Not sure it's worth reporting as the "title only" button exists in the UI which I clearly missed!

https://global-search.toolforge.org/?q=.*&regex=1&namespaces=8&title=Cite-tool-definition.json doesn't miss it and I can confirm using the wildcard search pattern at least there are no more missed messages.