| Volker_E | |
| Mar 28 2019, 10:32 PM |
| F28757525: image.png | |
| Apr 24 2019, 6:01 PM |
| F28757510: image.png | |
| Apr 24 2019, 6:01 PM |
| F28745289: Screen Shot 2019-04-23 at 10.00.37 AM.png | |
| Apr 23 2019, 5:01 PM |
| F28731786: image.png | |
| Apr 22 2019, 6:38 PM |
| F28500964: image.png | |
| Mar 28 2019, 10:32 PM |
The paragraphs followed by headings 3 should be provided bigger margin to emphasize hierarchy better
Proposed solution (staying in 0.5em MinervaNeue top/bottom margin multiplicator for now, we can follow up with 8px based later):
.content p + h3 { margin-top: 1.5em; }
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Increase `margin-top` for `h3` following `p` elements | mediawiki/skins/MinervaNeue | master | +5 -0 |
Change 500858 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Increase margin-top for h3 following p elements
Change 500858 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Increase margin-top for h3 following p elements
@Volker_E apologies for the delay. I've just checked on beta. It looks fine, though I don't see any difference from production. Is this expected?
@alexhollender Your screenshot shows the h3 alone, what we amended was h3 following a p, as the margin was not big enough there.
@Volker_E sorry for misunderstanding. Though I see no difference in the spacing above the h3 either? As I mentioned I am fine with signing this off, just trying to clarify if the patch is having the desired effect.
@alexhollender It has been merged and went out to production before the last cut. Therefore you can't see the difference any more. Here in retrospect the before/after state:
 |  |