Page MenuHomePhabricator
Create Task
Maniphest T219675

[Regression wmf.23] Searching image is broken on both Beta and test.wiki
Closed, ResolvedPublic
Actions

Description

Not sure if it is already reported somewhere or being worked on, but I can't search for any images using VE both on desktop and mobile.
Also not sure if it has anything to do with VE.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
MediaResultWidget: Remove unused code depending on VisualEditormediawiki/coremaster+0 -6
MediaResultWidget: Fix defaultThumbSzie configmediawiki/coremaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Mar 29 2019, 9:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2019, 9:21 PM
Ryasmeen added a comment.Mar 29 2019, 9:35 PM

So this is the error that appears in the console when it's failing: jQuery.Deferred exception: Cannot read property 'defaultthumbsize' of undefined TypeError: Cannot read property 'defaultthumbsize' of undefined

Schnark added subscribers: matmarex, Schnark.Mar 30 2019, 9:15 AM

Very likely caused by rEVED21e9db7d1339: Respect user preference for default thumbnail size while editing.

gerritbot added a comment.Mar 31 2019, 9:18 PM

Change 500362 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] MediaResultWidget: Fix defaultThumbSzie config

https://gerrit.wikimedia.org/r/500362

gerritbot added a project: Patch-For-Review.Mar 31 2019, 9:18 PM
Esanders claimed this task.Mar 31 2019, 9:18 PM
Esanders triaged this task as High priority.
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.
gerritbot added a comment.Mar 31 2019, 11:14 PM

Change 500362 merged by jenkins-bot:
[mediawiki/core@master] MediaResultWidget: Fix defaultThumbSzie config

https://gerrit.wikimedia.org/r/500362

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Apr 1 2019, 12:02 AM
matmarex added a comment.Apr 1 2019, 3:55 PM

Thank you for noticing this!

On a closer look, the faulty code is not even being used. Let's remove it.

gerritbot added a comment.Apr 1 2019, 3:55 PM

Change 500477 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] MediaResultWidget: Remove unused code depending on VisualEditor

https://gerrit.wikimedia.org/r/500477

gerritbot added a comment.Apr 1 2019, 9:07 PM

Change 500477 merged by jenkins-bot:
[mediawiki/core@master] MediaResultWidget: Remove unused code depending on VisualEditor

https://gerrit.wikimedia.org/r/500477

matmarex moved this task from Code review to QA on the VisualEditor (Current work) board.Apr 1 2019, 9:36 PM
Ryasmeen added a project: Verified.Apr 1 2019, 11:11 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Fixed now, Thanks BD! :)

ppelberg closed this task as Resolved.May 10 2019, 1:16 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMay 10 2019, 1:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits