Page MenuHomePhabricator

[Regression wmf.23] Searching image is broken on both Beta and test.wiki
Closed, ResolvedPublic

Description

Not sure if it is already reported somewhere or being worked on, but I can't search for any images using VE both on desktop and mobile.
Also not sure if it has anything to do with VE.

Event Timeline

So this is the error that appears in the console when it's failing: jQuery.Deferred exception: Cannot read property 'defaultthumbsize' of undefined TypeError: Cannot read property 'defaultthumbsize' of undefined

Change 500362 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] MediaResultWidget: Fix defaultThumbSzie config

https://gerrit.wikimedia.org/r/500362

Esanders triaged this task as High priority.
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 500362 merged by jenkins-bot:
[mediawiki/core@master] MediaResultWidget: Fix defaultThumbSzie config

https://gerrit.wikimedia.org/r/500362

Thank you for noticing this!

On a closer look, the faulty code is not even being used. Let's remove it.

Change 500477 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] MediaResultWidget: Remove unused code depending on VisualEditor

https://gerrit.wikimedia.org/r/500477

Change 500477 merged by jenkins-bot:
[mediawiki/core@master] MediaResultWidget: Remove unused code depending on VisualEditor

https://gerrit.wikimedia.org/r/500477