Page MenuHomePhabricator
Create Task
Maniphest T219687

Fix errors and warnings found via phpcs at Html2Wiki extension (tracking)
Closed, ResolvedPublic
Actions

Description

See https://zoranzoki21.github.io/wmf-stuff/patch-console1.txt

Details

SubjectRepoBranchLines +/-
Add phpcs in Html2Wiki extension and fix errors found by itmediawiki/extensions/Html2Wikimaster+1 K -1 K
Fix warnings found by phpcsmediawiki/extensions/Html2Wikimaster+1 K -1 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Kizule created this task.Mar 29 2019, 11:09 PM
Restricted Application edited projects, added User-Kizule; removed Patch-For-Review. · View Herald TranscriptMar 29 2019, 11:09 PM
gerritbot added a comment.Mar 29 2019, 11:11 PM

Change 500147 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Html2Wiki@master] Fix Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed warnings

https://gerrit.wikimedia.org/r/500147

gerritbot added a project: Patch-For-Review.Mar 29 2019, 11:11 PM
Kizule updated the task description. (Show Details)Mar 29 2019, 11:13 PM
Kizule added a comment.Mar 29 2019, 11:52 PM
This comment was removed by Kizule.
gerritbot added a comment.Aug 30 2019, 9:20 PM

Change 500147 abandoned by Zoranzoki21:
Fix warnings found by phpcs

Reason:
Will make new

https://gerrit.wikimedia.org/r/500147

gerritbot added a comment.Aug 30 2019, 9:31 PM

Change 500144 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Html2Wiki@master] Add phpcs in Html2Wiki extension and fix errors found by it

https://gerrit.wikimedia.org/r/500144

Kizule moved this task from Inbox to To deploy on the User-Kizule board.Nov 11 2019, 1:26 AM
gerritbot added a comment.Nov 12 2019, 4:30 PM

Change 500144 merged by jenkins-bot:
[mediawiki/extensions/Html2Wiki@master] Add phpcs in Html2Wiki extension and fix errors found by it

https://gerrit.wikimedia.org/r/500144

Jdforrester-WMF mentioned this in rEHTW3ed6249b3fc1: Add phpcs in Html2Wiki extension and fix errors found by it.Nov 12 2019, 4:34 PM
Kizule closed this task as Resolved.Nov 12 2019, 4:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL